Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which context file maps json web keys? #228

Closed
iherman opened this issue Jan 30, 2024 · 3 comments · Fixed by #229
Closed

Which context file maps json web keys? #228

iherman opened this issue Jan 30, 2024 · 3 comments · Fixed by #229
Assignees
Labels
editorial Editorial changes only has-pr

Comments

@iherman
Copy link
Member

iherman commented Jan 30, 2024

Example 12 (and possibly others) is invalid, because the JsonWebKey and publicKeyJwk terms are not defined by the two context files listed in the example (https://www.w3.org/ns/did/v1, https://www.w3.org/ns/credentials/v2).

I also checked the security vocabulary's context (https://w3id.org/security#) and it is not there either. Although these terms are properly defined in the DI vocabulary, it is as if no context file we have deals with them.

Isn't this odd? Shouldn't JsonWebKey and related terms be mentioned in one of the context files? Or should we create a new context file for them?

@dlongley @msporny @decentralgabe

@msporny
Copy link
Member

msporny commented Jan 30, 2024

Example 12 (and possibly others) is invalid, because the JsonWebKey and publicKeyJwk terms are not defined by the two context files listed in the example (https://www.w3.org/ns/did/v1, https://www.w3.org/ns/credentials/v2).

Yes, ideally a did/v2 context would include both. Until then, we'll have to pull the appropriate context in...

I also checked the security vocabulary's context (https://w3id.org/security#) and it is not there either.

Hmm... isn't this it? https://w3c.github.io/vc-data-integrity/vocab/security/vocabulary.html#JsonWebKey

Although these terms are properly defined in the DI vocabulary, it is as if no context file we have deals with them.

There is:

https://github.com/w3c/vc-data-integrity/blob/main/contexts/jwk/v1

Shouldn't JsonWebKey and related terms be mentioned in one of the context files? Or should we create a new context file for them?

did/v2 should include both key contexts... but that won't happen for another year or two. :)

In the meantime, people should include the context that defines JsonWebKey (see above).

@iherman
Copy link
Member Author

iherman commented Jan 30, 2024

Example 12 (and possibly others) is invalid, because the JsonWebKey and publicKeyJwk terms are not defined by the two context files listed in the example (https://www.w3.org/ns/did/v1, https://www.w3.org/ns/credentials/v2).

Yes, ideally a did/v2 context would include both. Until then, we'll have to pull the appropriate context in...

I also checked the security vocabulary's context (https://w3id.org/security#) and it is not there either.

Hmm... isn't this it? https://w3c.github.io/vc-data-integrity/vocab/security/vocabulary.html#JsonWebKey

That is the vocabulary. I meant the "vocabulary context", ie, https://w3id.org/security/data-integrity/v2. Sorry about the typo.

Although these terms are properly defined in the DI vocabulary, it is as if no context file we have deals with them.

There is:

https://github.com/w3c/vc-data-integrity/blob/main/contexts/jwk/v1

Ah. I did not know about this one! Where is it mentioned in the spec(s)? Shouldn't it? What is its "canonical" adress? Shouldn't it be something like https://w3id.org/security/data-integrity/jwk?

I presume the reason why it is not merged into the DI context is to avoid the (impression of) dependency of JOSE-COSE on DI...

Shouldn't JsonWebKey and related terms be mentioned in one of the context files? Or should we create a new context file for them?

did/v2 should include both key contexts... but that won't happen for another year or two. :)

In the meantime, people should include the context that defines JsonWebKey (see above).

O.k. Then the example (and others) should definitely be extended.

@iherman
Copy link
Member Author

iherman commented Jan 30, 2024

Ah. I did not know about this one! Where is it mentioned in the spec(s)? Shouldn't it? What is its "canonical" adress? Shouldn't it be something like https://w3id.org/security/data-integrity/jwk?

I presume the reason why it is not merged into the DI context is to avoid the (impression of) dependency of JOSE-COSE on DI...

Oops, sorry, I found it. The context is https://w3id.org/security/jwk/v1 and it is listed in https://www.w3.org/TR/vc-data-integrity/#contexts-and-vocabularies.

@iherman iherman self-assigned this Jan 30, 2024
@iherman iherman added has-pr editorial Editorial changes only labels Jan 30, 2024
@decentralgabe decentralgabe linked a pull request Jan 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Editorial changes only has-pr
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants