You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@decentralgabe This PR was merged without addressing my requested editorial change.
I think you're referring to this comment as your "requested editorial change".
Please note that your intent was not obvious because you did not submit it as a change request using the GitHub tooling, which would have shown the existing PR content --
Implementers SHOULD avoid setting JWT claims to values that conflict with
verifiable credential properties, especially with pairs such as
`iss` and `issuer`, `jti` and `id`, and `sub` and `credentialSubject.id`.
-- in contrast to your suggestion --
Implementers SHOULD avoid setting JWT claims to values that conflict with
verifiable credential properties when the claims and properties refer to the same concept, for example,
`iss` and `issuer`, `jti` and `id`, and `sub` and `credentialSubject.id`.
I suggest the following --
Implementers SHOULD avoid setting JWT claims to values that conflict with
the values of verifiable credential properties when a claim and property
pair refer to the same conceptual entity, especially with pairs such as
`iss` and `issuer`, `jti` and `id`, and `sub` and `credentialSubject.id`.
For example, JWK claim `iss` should not be set to a value which conflicts
with the value of verifiable credential property `issuer`.
I think this change should only touch this paragraph, is editorial, and hopefully is not controversial.
The text was updated successfully, but these errors were encountered:
Originally posted by @TallTed in #226 (comment)
Edited somewhat for posting as a new issue.
Answering @David-Chadwick's #226 (comment) --
I think you're referring to this comment as your "requested editorial change".
Please note that your intent was not obvious because you did not submit it as a change request using the GitHub tooling, which would have shown the existing PR content --
-- in contrast to your suggestion --
I suggest the following --
I think this change should only touch this paragraph, is editorial, and hopefully is not controversial.
The text was updated successfully, but these errors were encountered: