Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update F2.html #4128

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Update F2.html #4128

wants to merge 8 commits into from

Conversation

mbgower
Copy link
Contributor

@mbgower mbgower commented Nov 1, 2024

  • rephrased the introduction to include mention of assistive technology
  • removed example 3
  • updated outcome logic of checks 1 and 2
  • added a third condition to check 2

Resolves #4109

- removed example 3
- updated outcome logic of checks 1 and 2
- added a third condition to check 2
Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit c6bb6d0
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/6737775fb31ac6000830aff0
😎 Deploy Preview https://deploy-preview-4128--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

techniques/failures/F2.html Outdated Show resolved Hide resolved
mbgower and others added 2 commits November 1, 2024 06:36
modified the introduction to include the third check in test 2
@mbgower mbgower self-assigned this Nov 1, 2024
techniques/failures/F2.html Outdated Show resolved Hide resolved
techniques/failures/F2.html Outdated Show resolved Hide resolved
@bruce-usab
Copy link
Contributor

Discussed on backlog call 11-1. Concern on call with only having heading examples, since CSS can semantically be used to convey emphasis.

Pulled back expansion of the failure technique to include presentation markup detected by assistive technologies.
@mbgower
Copy link
Contributor Author

mbgower commented Nov 1, 2024

Created a new issue to track unincorporated changes #4132

techniques/failures/F2.html Outdated Show resolved Hide resolved
techniques/failures/F2.html Outdated Show resolved Hide resolved
@mbgower
Copy link
Contributor Author

mbgower commented Nov 15, 2024

Once the other non-structural changes have been added in the other Issue, the wording of the first check can be adjusted to something like the a prior commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maybe remove Example 3 of F2
3 participants