refact: API 스키마 및 에러 핸들링 개선 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minkyu97
commented
Aug 8, 2024
| @@ -17,15 +21,17 @@ async fn submit_code( | |||
| submission.language | |||
| ); | |||
|
|
|||
| let output = mark(MarkParams { | |||
| let output = AssertUnwindSafe(mark(MarkParams { | |||
There was a problem hiding this comment.
주의) 장기적으로는 futures::FutureExt::catch_unwind 와 std::panic::AssertUnwindSafe 를 걷어내고 hodu-core 의 응답을 Result 로 감싸는 것이 좋겠습니다.
woohm402
reviewed
Aug 8, 2024
Dockerfile.dev
Outdated
There was a problem hiding this comment.
Dockerfile.local 은 어때요? dev 는 약간 dev 환경에 대해 써야 되는 단어같아서요!
woohm402
approved these changes
Aug 8, 2024
|
어우 힘들어 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기존 코드의 문제점
기존에는 hodu core 의 채점 결과로부터 응답 스키마를 생성하는 코드가 너무 장황하고 boilerplaty 했다.
그리고 채점 중 에러 발생 시 에러를 캐치하지 않아서 요청이 abort 되었다.
리팩토링 방법
serde 의 다양한 속성들을 이용하여 응답 스키마 생성 로직을 단순화한다.
그리고 futures 크레이트를 추가하여 채점 중 발생한 에러를 핸들링 할 수 있도록 한다.
관련 링크
https://serde.rs/remote-derive.html
https://doc.rust-lang.org/std/panic/struct.AssertUnwindSafe.html
https://docs.rs/futures/latest/futures/future/trait.FutureExt.html#method.catch_unwind