Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offset objects that instantiate / forcemove objects to their loc should also offset said items #317

Open
MrMelbert opened this issue Aug 7, 2024 · 2 comments

Comments

@MrMelbert
Copy link

MrMelbert commented Aug 7, 2024

See protolathes, (which are not currently offset but should be, this is VV'd). Printing objects doesn't put it where the protolathe is.

This is particularly a problem because, well, it looks bad. But also in testmerges, people report that sometimes it can dispense items under windows (if a window was present on on the south side), and be unclickable. Haven't been able to reproduce this but it's a common report.

image

Things affected

  • Vending machines
  • Anything a mob drops

image

  • Microwaves (kinda?)
  • Other kitchen machines (processor, griddle, oven, grinder maybe? dehydrator, gibber, drying rack, deep fryer. most of these aren't offset though (but should be))
  • Protolathe (not offset but should be)
  • Autholathe (not offset but should be)
  • Circuit printer (not offset but should be)
  • deconstructive analyzer (not offset but should be)
  • chemmasters (not offset but should be)
  • chem dispeners (not offset but should be)
  • chem heaters (not offset but should be)
  • disposals bins (not offset but should be)
  • Restaurant portals (kinda, not offset but MAYBE should be)
  • photocopies (not offset but should be)
  • exosuit fabs (not offset but should be)
  • biogenerator
  • seed extractor
  • hydroponics tray (well these aren't offset, and i think they shouldn't be? but if someone does it then it's here for posterity)
  • arcades (didn't test)
  • fax machines (didn't test)
  • PANDEMIC (not offset but maybe should be)
  • washing machines (though maybe it's cute that they don't, they kinda dump it on the ground in front of them)
  • slime processor (not offset but should be)

Things affected only if you go out of your way

  • genetics consoles (with their disks)
  • pda painters (didn't test, not offset but should be)
  • mod PCs (didn't test)

Also:

  • Bits from dismantling a table (well, it goes to the base, which makes sense, but maybe we should offset them to center-of-mass)
    • Also racks (though not offset yet)
    • Actually, bits from dismantling ANYTHING.

image

And probably more... we instantiate a lot of objects

@tontyGH
Copy link

tontyGH commented Aug 11, 2024

this might be a naive solution but couldn't you just set the base_pixel of /obj/item/ to the depth offset and fix all of these at once

@tontyGH
Copy link

tontyGH commented Aug 11, 2024

^ tried this, looks pretty good and, aside from items going very slightly into walls when dropped, I couldn't find a situation in my like 5 minutes of testing that broke anything or looked bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants