Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generating fields color to proper rendering svg->pdf for asciidoc flow #36

Open
iDoka opened this issue Apr 8, 2022 · 1 comment

Comments

@iDoka
Copy link

iDoka commented Apr 8, 2022

The both, wavedrom and wavedrompy use hsl representation of colors for bitfield functionaluty.
It seems asciidoctor flow doesn't support hsl in svg well.

The svg files from wavedrom and wavedrompy rendering in Chrome:

Screenshot from 2022-04-07 21-56-39
Screenshot from 2022-04-07 21-56-30

The same svg from wavedrom and wavedrompy build in asciidoc and finally rendered as PDF:

Screenshot from 2022-04-07 21-55-47

I tried to make tiny fix to convert HSL->RGB:

Screenshot from 2022-04-08 16-08-30

iDoka@90dffcd

@iDoka iDoka changed the title Fix generating fields color to proper rendering svg->pdf rendering for asciidoc flow Fix generating fields color to proper rendering svg->pdf for asciidoc flow Apr 8, 2022
@wallento
Copy link
Owner

Thanks. I have cherry-picked that commit for inclusion in the next relase!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants