Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestCity BoundingBox has illegal specification #157

Open
robstoll opened this issue Dec 22, 2021 · 2 comments
Open

TestCity BoundingBox has illegal specification #157

robstoll opened this issue Dec 22, 2021 · 2 comments
Assignees
@robstoll
Labels
Bug

Comments

@robstoll
Copy link
Contributor

Now that we are checking bounding boxes we see that the bounding box of the TestCity is malformed
@robstoll robstoll added the Bug label Dec 22, 2021
@robstoll robstoll self-assigned this Dec 22, 2021
@robstoll robstoll added this to Board Dec 22, 2021
@robstoll
Copy link
Contributor Author

The problem was, that TestCity had minLat = maxLat which does not result in a box

@robstoll
Copy link
Contributor Author

Also, this causes an UnhandledPromiseRejectionWarning which will have the following undesired effect in the future:

DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will

@robstoll robstoll moved this to In Progress in Board Dec 22, 2021
robstoll added a commit to tegonal/datablue that referenced this issue Dec 22, 2021
@robstoll
water-fountains#148 fetch by bounds instead of city
aa6848b 
the /fountains endpoint now requires sw and ne query parameter instead of city

moreover:
- require a location for byId so that we can look it up in cache
- fix TestCityBounds (water-fountains#157)
- failure handling for cache populati
- send 404 in case json object is undefined (and not only log error
  and send undefined)
- catch errors and send to next middleware (water-fountains#155)
- removed database.service.ts
- increased REQUEST_LIMIT to 10MB as we query more fountains now
- updated Api.yaml accordingly
- updated express from 4.17.1 to 4.17.2
- update node-cache from 4.2.1 to 5.1.2

cleanup:
- use BoundingBox instead of separate minLng, minLat... as parameter
- added last_scan to FountainCollection and provide a factory function
  which set it automatically to new Date()
- fix binding in router.ts
@robstoll robstoll mentioned this issue Dec 22, 2021
Merged
@robstoll robstoll moved this from In Progress to Verify in Board Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robstoll robstoll

Labels
Bug
Projects
Board
Status: Verify
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robstoll