Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StateUIs does not reflect Cmd update #157

Open
wateret opened this issue Aug 10, 2019 · 0 comments
Open

StateUIs does not reflect Cmd update #157

wateret opened this issue Aug 10, 2019 · 0 comments
Labels
bug

Comments

@wateret
Copy link
Owner

wateret commented Aug 10, 2019 •
edited
Loading

Issue

  1. A StateUI is generated with a Cmd
  2. The Cmd is updated (e.g. by OnCmdEventEffect)
  3. StateUI does its work without Cmd changes

This happens when CriticalAttack is proceed correctly but the effect is not shown. It is because StateUI is written as static. Every param is fixed when it is generated and can never change.

Possible solution

  • Let StateUI hold a Cmd : Simple and clear. But do we have to? And.. why not?
@wateret wateret added the bug label Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wateret