Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running TO-DO for conventional BSM2 Flowsheet #1318

Open
1 of 11 tasks
Tracked by #934
adam-a-a opened this issue Feb 29, 2024 · 2 comments
Open
1 of 11 tasks
Tracked by #934

Running TO-DO for conventional BSM2 Flowsheet #1318

adam-a-a opened this issue Feb 29, 2024 · 2 comments
Assignees
Labels
iedo Priority:Normal Normal Priority Issue or PR

Comments

@adam-a-a
Copy link
Contributor

adam-a-a commented Feb 29, 2024

There are some outstanding to-do items for the BSM2 flowsheet, most of which were mentioned in #1244:

  • add temp dependence for KLa and consider moving to ASM prop models and off of cstr_injection unit
  • add temp dependence for S_O_eq and move to prop model
  • revisit origin of 1.8 factor and more general aeration energy equation; 1.8 may be the aeration efficiency which is oxygen mass transfer divided by power input
  • Resolve final iterations of BSM2 flowsheet having regularization Add Modified ADM1 flowsheet #1469
  • Probe model solutions across range of initial conditions as well as altering setup of optimization model
  • use Henry's law constant for co2 already created in ADM1 rxn model; remove the KH_co2 from anaerobic digester
  • move any other variables/parameters that shouldn't be on AD unit to props or reactions (K_La, KH_ch4, ...)
  • resolve the danger of redundant constraint related to pressure equality constraints created in Mixer unit, specifically for isobaric conditions. the mixer initializer will turn these constraints back on
  • consider adding costs for mixers, separators, any auxiliary units that aren't explicitly costed (without double counting)
  • change ref to m.fs.Treated instead of CL1 effluent in add_effluent_violations function
  • revisit rector volume equality constraints used to facilitate optimization of AS reactor volumes
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Feb 29, 2024
@adam-a-a adam-a-a added the iedo label Mar 1, 2024
@adam-a-a adam-a-a changed the title Running TO-DO for BSM2 Flowsheet Running TO-DO for conventional BSM2 Flowsheet Jul 25, 2024
@adam-a-a
Copy link
Contributor Author

We should revisit " Resolve final iterations of BSM2 flowsheet having regularization" and make sure this wasn't confused with ending in restoration. Either way, let's check the conventional BSM2 flowsheet solver output.

@adam-a-a
Copy link
Contributor Author

change ref to m.fs.Treated instead of CL1 effluent in add_effluent_violations function

@MarcusHolly attempted to make this change, but for some reason, it caused test failures for the GUI, and so the changes were undone. We should revisit this issue at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iedo Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

No branches or pull requests

4 participants