Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to disable Milo rules? #77

Open
nicoleescobar opened this issue Feb 8, 2021 · 3 comments
Open

Is it possible to disable Milo rules? #77

nicoleescobar opened this issue Feb 8, 2021 · 3 comments

Comments

@nicoleescobar
Copy link
Member

Hello!, I'm working on a Hugo website with Tailwind CSS integrated, and there are a few components that have SVGs set on the HTML, the SVGs tags have an attribute called "viewBox" and it is firing the attr-lowercase rule and that's why I've been bitten by Milo.

@paganotoni
Copy link
Member

Ah! This is one that I've seen as well. Yes, you can disable rules by using the .milo.yml file but I'm thinking if we should consider SVG and how do we deal with it.

cc @larrymjordan @tatang26

@larrymjordan
Copy link
Contributor

@paganotoni agreed!, I think we can add all of already-known SVG attributes to a whitelist and apply it only to SVG elements, probably that would solve this issue, however your statement makes me wondering what other cases we should cover and give SVG elements a different treatment. Any thoughts?

@paganotoni
Copy link
Member

That sounds good to me. Probably as a side topic I wonder if the HTML standard or the Go HTML parser we have considers SVG document sections any different than the rest of the document and that something we could use to know the element we're seeing is inside SVG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants