Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color highlighting of helpers / functions compared to erb #9

Open
saurori opened this issue Nov 23, 2022 · 3 comments
Open

Color highlighting of helpers / functions compared to erb #9

saurori opened this issue Nov 23, 2022 · 3 comments

Comments

@saurori
Copy link

saurori commented Nov 23, 2022

👋 Hey - thanks for creating this extension. I have been using erb as a Language Mode for .plush.html templates, which works well. When comparing this extension to erb, I noticed that variable/object highlighting in helper functions takes the same color as strings, or is just white. It would help to differentiate. See the images for an example:

ERB:
Imgur

Visho:
Imgur

Also sometimes the params are just white:

ERB:
Imgur

Visho:
Imgur

@YanDeLeon
Copy link
Collaborator

Hey @saurori 👋🏼!! Thank you for taking the time and open this Issue. It is a very good point.

For sure we'll work on that

@paganotoni
Copy link
Member

paganotoni commented Nov 29, 2022

Hey @saurori, there have been some improvements to this that I wanted to bring up with you. So far this is how it's looking:

CleanShot 2022-11-29 at 15 52 25@2x

@saurori
Copy link
Author

saurori commented Nov 29, 2022

@paganotoni Looks better! I do prefer the color scheme on the erb highlighting though (I'm using the Dark+ theme).

Imgur

Imgur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants