Skip to content
This repository has been archived by the owner on Nov 29, 2022. It is now read-only.

docstrings Issue: scoring_method and scoring_cutoff #35

Open
shaddyab opened this issue Oct 21, 2019 · 1 comment
Open

docstrings Issue: scoring_method and scoring_cutoff #35

shaddyab opened this issue Oct 21, 2019 · 1 comment

Comments

@shaddyab
Copy link

shaddyab commented Oct 21, 2019 •
edited
Loading

Description of the scoring_method and scoring_cutoff exists in the docstrings of derivatives.py but not in base.py.
In addition the default values for scoring_method is inconsistent in both files. I will create a pull Request once I have a chance.

See PR #32
@rsyi
Copy link
Contributor

rsyi commented Oct 29, 2019 •
edited
Loading

Hey @shaddyab thanks for this. Could you make this PR to https://github.com/df-foundation/pylift ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shaddyab @rsyi