Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub pull request template #539

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update GitHub pull request template #539

wants to merge 1 commit into from

Conversation

vikman90
Copy link
Member

Description

This pull request aims to update the existing pull request template to improve its structure, clarity, and usefulness during the review process. The current template lacked certain key sections and checklists that would help ensure thorough reviews and proper documentation of changes.

Closes #536.

Proposed Changes

  • Added Configuration changes and Documentation updates sections to document any modifications to configuration files or parameters.
  • Split the Evidence of changes and Tests introduced into dedicated sections for better organization.
  • Introduced a Review checklist for manual tests and pending tasks, helping contributors track what’s needed for approval.

Results and Evidence

image

Artifacts Affected

None.

Review Checklist

  • Code changes reviewed
  • Relevant evidence provided
  • Meets requirements and/or definition of done
  • No unresolved dependencies with other issues

@vikman90 vikman90 added the type/change Change performed in a resource or Wazuh Cloud environment label Jan 24, 2025
@vikman90 vikman90 self-assigned this Jan 24, 2025
@vikman90 vikman90 linked an issue Jan 24, 2025 that may be closed by this pull request
Update the pull request template #536
Open
@vikman90 vikman90 marked this pull request as ready for review January 24, 2025 12:03
cborla
cborla approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@cborla cborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cborla cborla cborla approved these changes

@MarcelKemp MarcelKemp MarcelKemp approved these changes

@TomasTurina TomasTurina TomasTurina approved these changes

Assignees

@vikman90 vikman90

Labels
type/change Change performed in a resource or Wazuh Cloud environment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the pull request template
4 participants
@vikman90 @TomasTurina @MarcelKemp @cborla