Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing as many modifications to the rendered DOM as possible #3278

Closed
mpRegalado opened this issue May 20, 2021 · 1 comment
Closed

Removing as many modifications to the rendered DOM as possible #3278

mpRegalado opened this issue May 20, 2021 · 1 comment
Labels
component/discover Issue related to the Wazuh discover component used to present events within our application. pending-PO Taks pending for PO validation and priorization type/enhancement Enhancement issue

Comments

@mpRegalado
Copy link
Member

The issue
In several parts of the code, most notably in the sections regarding the Discovery Legacy tables, the application executes as follows:

  1. The data is rendered through the Discovery Plugin
  2. An external function waits a specified time and checks whether the table has loaded and
  3. the external function goes through each element of the table and modifies it as needed.
    This causes the code to be slower and less efficient, as well as harder to maintain.
    The proposed solution
    It would be a good idea to move the functionality of these functions into encapsulated function calls that are executed at render time for the table, having these functions in a library outside of the discover plugin in order to make possible upgrades to the plugin as simple as possible.
    Some files that are affected
  • The method enhanceDiscoverEventsCell in public/components/common/modules/events-enhance-discover-fields.ts and enhanceDiscoverTableAddObservers in public/components/common/modules/events.tsx affect the rows rendered in the file public/kibana-integrations/discover/application/components/table/table_row.tsx
@mpRegalado mpRegalado added the type/enhancement Enhancement issue label May 20, 2021
@frankeros frankeros added the pending-PO Taks pending for PO validation and priorization label May 26, 2021
@AlexRuiz7 AlexRuiz7 added the component/discover Issue related to the Wazuh discover component used to present events within our application. label May 10, 2022
@Desvelao
Copy link
Member

The discover table was replaced in the current application #6120, so this is outdated and could be closed as not planned.

@Desvelao Desvelao closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/discover Issue related to the Wazuh discover component used to present events within our application. pending-PO Taks pending for PO validation and priorization type/enhancement Enhancement issue
Projects
None yet
Development

No branches or pull requests

4 participants