Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: htmlparser2 causes performance degradation #1592

Closed
chenjiahan opened this issue Nov 17, 2024 · 1 comment · Fixed by #1600
Closed

[Bug]: htmlparser2 causes performance degradation #1592

chenjiahan opened this issue Nov 17, 2024 · 1 comment · Fixed by #1600
Assignees
Labels
🐞 bug Something isn't working

Comments

@chenjiahan
Copy link
Member

chenjiahan commented Nov 17, 2024

Version

latest

Details

In #1557, htmlparser2 has been added to the client code, making it becomes the largest runtime dependency of Rspress:

Image

In general, it is not a good idea to parse HTML on the browser side, as this will affect both the bundle size and runtime performance. I suggest that we process HTML in Node.js or use a lighter solution in the browser.

Reproduce link

/

Reproduce Steps

main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants