Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ESW10-USA broke #158

Closed
JeffSteinbok opened this issue Nov 8, 2022 · 8 comments
Closed

Support for ESW10-USA broke #158

JeffSteinbok opened this issue Nov 8, 2022 · 8 comments

Comments

@JeffSteinbok
Copy link

Noticed that ESW10-USA switches no longer work.
Looks like the refactor out to vesyncoutlet.py may have broken it.

@sdrapha
Copy link
Contributor

sdrapha commented Nov 8, 2022

ESW10-USA wasn't in the list of supported devices, see #61 and #62.

@JeffSteinbok
Copy link
Author

Can you folks update this then? Says it supports.

I’ll return these I guess.

https://www.home-assistant.io/integrations/vesync

@sdrapha
Copy link
Contributor

sdrapha commented Nov 8, 2022

I went forensic mode; both python library nor homeassistant provide support to this device. That HA documentation is misleading and seem to be there, as is, for about 3 years

The PR to add it is already out there, but I don't have any say on that, I just follow the discussions since I'm subscribed to the repo. If I had that device I could test, to help reviewing the code, but I don't have it. Maybe you could test it and review it, so webdjoe could merge that pr.

Otherwise, the alternative would be making a PR to fix the HA documentation and remove those. That I can do. Or anyone really.

@webdjoe
Copy link
Owner

webdjoe commented Nov 8, 2022

The PR to add the device type is very old and there was a comment that the on-off functionality was not working. I'm sure it would be a simple addition, but I would need the captures to get it integrated.

@JeffSteinbok
Copy link
Author

I did try to tweak the code so that it maps it to VeSyncOutlet10A just like some others, but it could get the values, but not set. I'll note also that this outlet doesn't have the power monitoring functionality of the other ones, so HA gave some errors there.

I'm happy to run this again and capture some packets if you can point me at some instructions on how to do so. I'm new to Python and such, but I can figure it out if there are some instructions.

@webdjoe
Copy link
Owner

webdjoe commented Nov 8, 2022

No python needed to capture packets - any iOS device can be used with Charles Proxy installed on a computer. Install the Charles Proxy SSL certificate on the ios device and just run vesync app and perform functions with the outlet you are looking to capture. Copy the url endpoint, request and response body and post here. Please redact the values but leave the keys for cid, uuid, account_id and token

@webdjoe
Copy link
Owner

webdjoe commented Sep 4, 2023

No activity for a while, I am closing this issue. Please start a new issue if you are able to capture packets.

@webdjoe webdjoe closed this as completed Sep 4, 2023
@langholdt
Copy link

Hello Webdjoe-
I recently "got" 10 of these devices and just started working with Home Assistant. I'm not real savvy at this, but if you could assist, I could send you a device to see if it's a quick fix. LMK.

Terry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants