Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github actions #164

Open
cdnninja opened this issue Dec 2, 2022 · 2 comments
Open

github actions #164

cdnninja opened this issue Dec 2, 2022 · 2 comments
Labels
enhancement New feature or request future

Comments

@cdnninja
Copy link
Contributor

cdnninja commented Dec 2, 2022

Before I create some PRs thoughts on github actions to help automate releases?

Thinking roughly what I run for https://github.com/Hyundai-Kia-Connect/hyundai_kia_connect_api

So semantic versioning that auto uploads to pypi. I noticed a home assistant PR for a version not listed here so looks like things aren't fully in sync. Can also do dependabot etc.
@webdjoe
Copy link
Owner

webdjoe commented Dec 2, 2022

Most of these checks are already done in azure pipelines - I have pytest, pylint, flake8 and mypy checks. I'm not a huge fan of pipelines but I hesitate to waste time changing when it does what it is supposed to do. Is there an additional check that you think should be added?

@cdnninja
Copy link
Contributor Author

cdnninja commented Dec 5, 2022

That is great to hear! Having it in github would show for all PRs but if you are the primary dev not much help on that.

The other item will be semantic releases to make sure this feedback is held in lockstep:

home-assistant/core#83146

@webdjoe webdjoe added enhancement New feature or request future labels Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request future
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdnninja @webdjoe