Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display graphics results in autograder output #10

Open
sravanareddy opened this issue Jun 22, 2016 · 6 comments
Open

Display graphics results in autograder output #10

sravanareddy opened this issue Jun 22, 2016 · 6 comments
Assignees
Labels

Comments

@sravanareddy
Copy link
Contributor

(in case we don't develop perfect graphics-grading functionality...)

Define a class of test cases where there is no expected result -- the autograder simply displays the resulting picture (take the cs1graphics output and save it as a png), and the expected image. Use the quilt task as an example.

@sravanareddy
Copy link
Contributor Author

To allow displayPic calls without the second argument, for backwards compatibility of other functions that may be calling it, define a default value

def displayPic(pic, filename=None)

and have it save to file only when filename is not None.

dkreimer added a commit that referenced this issue Jun 29, 2016
needs testing. should i also assume that the student’s function return
the image link? that’s what i’m going with but i started wondering.
finishing this tomorrow morning.
dkreimer added a commit that referenced this issue Jun 29, 2016
…10)

The problem is that picture.py crashes and freezes when doing the quilts
@sravanareddy
Copy link
Contributor Author

Need to look into why saveToFile is not halting the program...

@sravanareddy
Copy link
Contributor Author

sravanareddy commented Jun 30, 2016

On investigation, it appears the quilt is too large (892 primitive objects, going 9 levels deep). The method works fine on simpler objects.

Some preliminary testing suggests that 500 objects is its breaking point.

@dkreimer
Copy link
Contributor

So that's not something we can fix, is it?

@sravanareddy
Copy link
Contributor Author

Not easily, but I'm going to look into it.

Worst case, we can simplify the quilt a little bit without sacrificing its aesthetics/difficulty. Or, we can test an intermediate function -- for example, each quadrant is only 223 objects/8 levels, and going from there to the final step is straightforward.

@sravanareddy sravanareddy added this to the Week 5: Misc features milestone Jun 30, 2016
@sravanareddy
Copy link
Contributor Author

Update for our records: waiting on LTS to install PIL on Canopy so we can test this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants