Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict usage of Context #11

Open
2 tasks
SebastianKuesters opened this issue Oct 22, 2022 · 0 comments
Open
2 tasks

Strict usage of Context #11

SebastianKuesters opened this issue Oct 22, 2022 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@SebastianKuesters
Copy link
Member

The usage to dependencies like the ISpaceBlocksContext should be limited to the Authorization pre-processor. All information which is needed for pre-, post- and main-handling of a command should be part of the command.

  • Log warning if a dependency which is registered for storing along delayed commands is used as parameter of pre-; post- oder handler
  • Document this decision

The goal of this is to avoid chaos. Moreover a developer directly sees all information which is required to execute the command without checking the processors and handler implementation.

@SebastianKuesters SebastianKuesters self-assigned this Oct 22, 2022
@SebastianKuesters SebastianKuesters added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant