Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for existed password input-group #25

Open
Mukhametvaleev opened this issue Aug 14, 2017 · 0 comments
Open

Check for existed password input-group #25

Mukhametvaleev opened this issue Aug 14, 2017 · 0 comments
Labels
enhancement

Comments

@Mukhametvaleev
Copy link

Mukhametvaleev commented Aug 14, 2017 •
edited
Loading

I am already have password .input-group with pre-prended .input-group-addon and i want to append show password button after password field. How should i implement that to existed .input-group?

> <div class="form-group input-group">
>     <span class="input-group-addon"><i class="fa fa-lock"></i></span>
>     <input type="password" class="form-control" placeholder="Password">
> </div>
jpalmieri pushed a commit to hinge-health/bootstrap-show-password that referenced this issue Jun 20, 2019
Changes to be compatible with our AQ reg form
c7f7bb3 
Main problem is that the library doesn't work well with a password input
that is already part of a bootstrap 'input group', since this library
wraps the password input field and the 'show password' icon in an input
group, resulting in a nested input group (and visual garbage). This is
documented here: wenzhixin#25

This removes that wrapper, and also appends the icon to the end of the
input group div, so that it plays nicely with our bootstrap-validator
error div.

See https://github.com/hinge-health/basilisk/pull/509 for more info.
@jpalmieri jpalmieri mentioned this issue Jun 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wenzhixin @Mukhametvaleev