From 433dcd9b781ae816e9ff1809aae7743d093476d2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc-Andr=C3=A9=20Garneau?= Date: Fri, 10 Jan 2025 13:54:20 -0500 Subject: [PATCH] Feedback: adding PII Scrub to the PFT --- _data/sites.json | 27 ++++++++++++----- _data/templates.json | 12 ++++++++ package-lock.json | 4 +-- package.json | 2 +- sites/feedback/assets/page-feedback-en.html | 32 +++++++++++++++++++-- sites/feedback/assets/page-feedback-fr.html | 32 +++++++++++++++++++-- sites/feedback/feedback-docs-en.html | 2 +- sites/feedback/feedback-docs-fr.html | 2 +- sites/feedback/index.json-ld | 27 ++++++++++++----- 9 files changed, 117 insertions(+), 23 deletions(-) diff --git a/_data/sites.json b/_data/sites.json index d2cf0b1a43..547dca6f5f 100644 --- a/_data/sites.json +++ b/_data/sites.json @@ -645,10 +645,10 @@ "en": "Documentation on how to use the elements of the feedback area.", "fr": "Documentation sur l'utilisation des éléments de la zone commentaires." }, - "modified": "2024-07-19", + "modified": "2025-01-09", "componentName": "feedback", "status": "stable", - "version": "2.1", + "version": "2.0.1", "pages": { "docs": [ { @@ -729,10 +729,20 @@ }, "dependencies": { "en": [ - { "title": "Page details", "url": "https://wet-boew.github.io/GCWeb/sites/page-details/page-details-docs-en.html", "component": "page-details" } + { "title": "Page details", "url": "https://wet-boew.github.io/GCWeb/sites/page-details/page-details-docs-en.html", "component": "page-details" }, + { "title": "Postback", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-postback/wb-postback-en.html", "component": "postback" }, + { "title": "PII Scrub", "url": "https://wet-boew.github.io/wet-boew/docs/ref/pii-postback/pii-scrub-en.html", "component": "pii-scrub" }, + { "title": "Data JSON", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-data-json/wb-data-json-en.html", "component": "wb-data-json" }, + { "title": "JSON Manager", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-jsonmanager/wb-jsonmanager-en.html", "component": "wb-json-manager" }, + { "title": "Do Action", "url": "https://wet-boew.github.io/GCWeb/components/wb-doaction/doaction-doc-en.html", "component": "doaction" } ], "fr": [ - { "title": "Détails de la page", "url": "https://wet-boew.github.io/GCWeb/sites/page-details/page-details-docs-fr.html", "component": "page-details" } + { "title": "Détails de la page", "url": "https://wet-boew.github.io/GCWeb/sites/page-details/page-details-docs-fr.html", "component": "page-details" }, + { "title": "Envoie de formulaire via Ajax", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-postback/wb-postback-fr.html", "component": "postback" }, + { "title": "Nettoyage d'IPI", "url": "https://wet-boew.github.io/wet-boew/docs/ref/pii-postback/pii-scrub-fr.html", "component": "pii-scrub" }, + { "title": "Data JSON", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-data-json/wb-data-json-fr.html", "component": "wb-data-json" }, + { "title": "Gestionnaire JSON", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-jsonmanager/wb-jsonmanager-fr.html", "component": "wb-json-manager" }, + { "title": "Do Action", "url": "https://wet-boew.github.io/GCWeb/components/wb-doaction/doaction-doc-fr.html", "component": "doaction" } ] }, "a11yGuidance": "no accessibility guidance", @@ -1024,10 +1034,12 @@ }, "notes": { "en": [ + "In order for your PFT to benefit from the personal information screening tool, you have to make sure your version of WET-BOEW is at 4.0.84 or higher.", "To upgrade from the RAP to the PFT, follow the instructions of the \"Upgrade from RAP\" tab.", "For more information about Data Ajax plugin, please visit Data Ajax documentation page." ], "fr": [ + "Pour que votre ORP puisse bénéficier de l'outil de filtrage des informations personnelles, vous devez vous assurer que votre version de WET-BOEW est supérieure ou égalse à 4.0.84.", "Pour passer du SUP au ORP, suivez les instructions de l'onglet \"Mise à jour à partir de SUP\".", "Pour plus d'informations sur le plugin Data Ajax, veuillez visiter la page de documentation Data Ajax." ] @@ -1615,12 +1627,13 @@ "iteration": [ { "@id": "_:iteration_pft_2", - "name": "Page feedback tool - Iteration 1.1", - "date": "2024-07", + "name": "Page feedback tool - Iteration 2", + "date": "2025-01", "detectableBy": "#gc-pft:has(.gc-pft-no p[role=\"status\"]:nth-of-type(2))", "fixes": [ "AJAX fragment: Added pageData to the French variant", - "AJAX fragment: Changed aria-live=\"polite\" to role=\"status\" in \"Tell us why below:\"." + "AJAX fragment: Changed aria-live=\"polite\" to role=\"status\" in \"Tell us why below:\".", + "AJAX fragment: Added PII scrub of the comment field." ], "predecessor": "_:iteration_pft_1", "assets": [ diff --git a/_data/templates.json b/_data/templates.json index 7295001942..3f958effd8 100644 --- a/_data/templates.json +++ b/_data/templates.json @@ -1486,6 +1486,18 @@ "language": "fr", "path": "topic-doc-fr.html" } + ], + "reports": [ + { + "title": "Accessibility assessment #1 - GC topic template", + "language": "en", + "path": "reports/a11y-1-en.html" + }, + { + "title": "Évaluation d'accessibilité #1 - Gabarits de page de sujet GC", + "language": "fr", + "path": "reports/a11y-1-fr.html" + } ] }, "dependencies": { diff --git a/package-lock.json b/package-lock.json index 4ebb59211a..d689e77b50 100644 --- a/package-lock.json +++ b/package-lock.json @@ -10,7 +10,7 @@ "license": "MIT", "dependencies": { "bootstrap-sass": "3.4.1", - "wet-boew": "github:wet-boew/wet-boew#v4.0.83" + "wet-boew": "github:garneauma/wet-boew#wb-data-scrub" }, "devDependencies": { "@lodder/grunt-postcss": "^3.0.1", @@ -13537,7 +13537,7 @@ }, "node_modules/wet-boew": { "version": "4.0.83", - "resolved": "git+ssh://git@github.com/wet-boew/wet-boew.git#996ffd12786dcfe881f6064996fd8bcfdaa8b921", + "resolved": "git+ssh://git@github.com/garneauma/wet-boew.git#ea65ca174216af92e8d9c10e55d1cfc3b544de34", "license": "MIT", "dependencies": { "bootstrap-sass": "3.4.1", diff --git a/package.json b/package.json index f9262b0fd0..b34c9f8437 100644 --- a/package.json +++ b/package.json @@ -13,7 +13,7 @@ "license": "MIT", "dependencies": { "bootstrap-sass": "3.4.1", - "wet-boew": "github:wet-boew/wet-boew#v4.0.83" + "wet-boew": "github:garneauma/wet-boew#wb-data-scrub" }, "browserslist": [ "last 2 versions", diff --git a/sites/feedback/assets/page-feedback-en.html b/sites/feedback/assets/page-feedback-en.html index c490bee556..375bbf82b6 100644 --- a/sites/feedback/assets/page-feedback-en.html +++ b/sites/feedback/assets/page-feedback-en.html @@ -15,7 +15,35 @@

Give feedback about this page

-
+ +

Maximum 300 characters

- +
diff --git a/sites/feedback/assets/page-feedback-fr.html b/sites/feedback/assets/page-feedback-fr.html index bcbbcf23a9..5f8e26c43c 100644 --- a/sites/feedback/assets/page-feedback-fr.html +++ b/sites/feedback/assets/page-feedback-fr.html @@ -15,7 +15,35 @@

Donnez votre rétroaction sur cette page

- + +

Maximum de 300 caractères

- +
diff --git a/sites/feedback/feedback-docs-en.html b/sites/feedback/feedback-docs-en.html index a310c5da16..0757e318f2 100644 --- a/sites/feedback/feedback-docs-en.html +++ b/sites/feedback/feedback-docs-en.html @@ -4,7 +4,7 @@ "title_section": "GCWeb (the Canada.ca theme in WET)", "language": "en", "altLangPage": "feedback-docs-fr.html", - "dateModified": "2023-11-08", + "dateModified": "2025-01-09", "layout": "documentation", "index_json": "index.json-ld", "before_start_ajax_url": "dto-guidance-en.html #beforeYouBegin" diff --git a/sites/feedback/feedback-docs-fr.html b/sites/feedback/feedback-docs-fr.html index 3fb3092e49..7f80cfd95f 100644 --- a/sites/feedback/feedback-docs-fr.html +++ b/sites/feedback/feedback-docs-fr.html @@ -4,7 +4,7 @@ "title_section": "GCWeb (le thème de Canada.ca dans la BOEW)", "language": "fr", "altLangPage": "feedback-docs-en.html", - "dateModified": "2023-11-08", + "dateModified": "2025-01-09", "layout": "documentation", "index_json": "index.json-ld", "before_start_ajax_url": "dto-guidance-fr.html #beforeYouBegin" diff --git a/sites/feedback/index.json-ld b/sites/feedback/index.json-ld index 7ac4b5f740..5065d8266b 100644 --- a/sites/feedback/index.json-ld +++ b/sites/feedback/index.json-ld @@ -14,10 +14,10 @@ "en": "Documentation on how to use the elements of the feedback area.", "fr": "Documentation sur l'utilisation des éléments de la zone commentaires." }, - "modified": "2024-07-19", + "modified": "2025-01-09", "componentName": "feedback", "status": "stable", - "version": "2.1", + "version": "2.0.1", "pages": { "docs": [ { @@ -98,10 +98,20 @@ }, "dependencies": { "en": [ - { "title": "Page details", "url": "https://wet-boew.github.io/GCWeb/sites/page-details/page-details-docs-en.html", "component": "page-details" } + { "title": "Page details", "url": "https://wet-boew.github.io/GCWeb/sites/page-details/page-details-docs-en.html", "component": "page-details" }, + { "title": "Postback", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-postback/wb-postback-en.html", "component": "postback" }, + { "title": "PII Scrub", "url": "https://wet-boew.github.io/wet-boew/docs/ref/pii-postback/pii-scrub-en.html", "component": "pii-scrub" }, + { "title": "Data JSON", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-data-json/wb-data-json-en.html", "component": "wb-data-json" }, + { "title": "JSON Manager", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-jsonmanager/wb-jsonmanager-en.html", "component": "wb-json-manager" }, + { "title": "Do Action", "url": "https://wet-boew.github.io/GCWeb/components/wb-doaction/doaction-doc-en.html", "component": "doaction" } ], "fr": [ - { "title": "Détails de la page", "url": "https://wet-boew.github.io/GCWeb/sites/page-details/page-details-docs-fr.html", "component": "page-details" } + { "title": "Détails de la page", "url": "https://wet-boew.github.io/GCWeb/sites/page-details/page-details-docs-fr.html", "component": "page-details" }, + { "title": "Envoie de formulaire via Ajax", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-postback/wb-postback-fr.html", "component": "postback" }, + { "title": "Nettoyage d'IPI", "url": "https://wet-boew.github.io/wet-boew/docs/ref/pii-postback/pii-scrub-fr.html", "component": "pii-scrub" }, + { "title": "Data JSON", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-data-json/wb-data-json-fr.html", "component": "wb-data-json" }, + { "title": "Gestionnaire JSON", "url": "https://wet-boew.github.io/wet-boew/docs/ref/wb-jsonmanager/wb-jsonmanager-fr.html", "component": "wb-json-manager" }, + { "title": "Do Action", "url": "https://wet-boew.github.io/GCWeb/components/wb-doaction/doaction-doc-fr.html", "component": "doaction" } ] }, "a11yGuidance": "no accessibility guidance", @@ -393,10 +403,12 @@ }, "notes": { "en": [ + "In order for your PFT to benefit from the personal information screening tool, you have to make sure your version of WET-BOEW is at 4.0.84 or higher.", "To upgrade from the RAP to the PFT, follow the instructions of the \"Upgrade from RAP\" tab.", "For more information about Data Ajax plugin, please visit Data Ajax documentation page." ], "fr": [ + "Pour que votre ORP puisse bénéficier de l'outil de filtrage des informations personnelles, vous devez vous assurer que votre version de WET-BOEW est supérieure ou égalse à 4.0.84.", "Pour passer du SUP au ORP, suivez les instructions de l'onglet \"Mise à jour à partir de SUP\".", "Pour plus d'informations sur le plugin Data Ajax, veuillez visiter la page de documentation Data Ajax." ] @@ -984,12 +996,13 @@ "iteration": [ { "@id": "_:iteration_pft_2", - "name": "Page feedback tool - Iteration 1.1", - "date": "2024-07", + "name": "Page feedback tool - Iteration 2", + "date": "2025-01", "detectableBy": "#gc-pft:has(.gc-pft-no p[role=\"status\"]:nth-of-type(2))", "fixes": [ "AJAX fragment: Added pageData to the French variant", - "AJAX fragment: Changed aria-live=\"polite\" to role=\"status\" in \"Tell us why below:\"." + "AJAX fragment: Changed aria-live=\"polite\" to role=\"status\" in \"Tell us why below:\".", + "AJAX fragment: Added PII scrub of the comment field." ], "predecessor": "_:iteration_pft_1", "assets": [