Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue dealing with concurrent requests #6

Open
tobie opened this issue May 31, 2018 · 1 comment
Open

Issue dealing with concurrent requests #6

tobie opened this issue May 31, 2018 · 1 comment

Comments

@tobie
Copy link

tobie commented May 31, 2018

Root cause of whatwg/html#3726 seems to be that wattsi doesn't handle concurrent requests properly.

When pr-preview serializes the requests to the wattsi server, everything works fine.

If those requested are parallelized, the wattsi server returns partially empty zip files for one of the two requests.

This problem only surfaced recently.

@tobie
Copy link
Author

tobie commented May 31, 2018

Note that as pr-preview itself may handle multiple requests in parallel and that other services also rely on wattsi-server, it is very possible to have concurrent requests to wattsi server despite pr-preview now serializing requests within each pull request. That's an effective band aid, not a complete solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant