Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional password to hub #842

Open
whyboris opened this issue Jan 30, 2024 · 8 comments
Open

Add optional password to hub #842

whyboris opened this issue Jan 30, 2024 · 8 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@whyboris
Copy link
Owner

whyboris commented Jan 30, 2024

⚠️ this would not be "super secure" but simply to prevent snooping by someone.

People over the years requested this 🤷‍♂️ seems easy to implement 😅

note: this means opening the .vha2 file one can easily read the password 👌 ... though to make it more secure we can (salt and then) hash the password and check the hash 🥳

@whyboris whyboris added the good first issue Good for newcomers label Jan 30, 2024
@whyboris
Copy link
Owner Author

I'm open to the discussion:

Should the (optional!) password be for the app or per hub?

@minazaher
Copy link

Can I work on this issue?

@whyboris
Copy link
Owner Author

Hey @minazaher thank you for the offer! Please give this a go 🤝

Please let me know if you have any questions along the way - I'm happy to assist 😁

For the user to add / remove / change the password - let's put the UI in the 4th tab in settings ("Current hub")

@olorunfemisamuel
Copy link

olorunfemisamuel commented Sep 17, 2024

Can I work on this issue, too?

@whyboris
Copy link
Owner Author

Hey @olorunfemisamuel - please feel free to try this issue out 🤝
Let me know if you have any questions along the way 👍

@ayyash1
Copy link

ayyash1 commented Oct 16, 2024

Can you /assign this to me?

@whyboris
Copy link
Owner Author

Hey @ayyash1 - let me know if you have any questions as you try adding this feature 🤝

@whyboris
Copy link
Owner Author

Thank you @ayyash1 for the Pull Request #865 🙇‍♂️ - I intend to merge it when I resume work on VHA this winter 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants