From 2f2cb160da6b7ebfdbc2a71c73329c5caaddc5c5 Mon Sep 17 00:00:00 2001 From: khermano Date: Thu, 13 Feb 2025 15:58:07 +0100 Subject: [PATCH] [WFCORE-6843] Logging a WARN if a deployment's runtime name doesn't have an extension --- .../deployment/ServerGroupDeploymentAddHandler.java | 5 +++++ .../jboss/as/server/deployment/DeploymentHandlerUtil.java | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/host-controller/src/main/java/org/jboss/as/domain/controller/operations/deployment/ServerGroupDeploymentAddHandler.java b/host-controller/src/main/java/org/jboss/as/domain/controller/operations/deployment/ServerGroupDeploymentAddHandler.java index ba294a421ce..15931ef886f 100644 --- a/host-controller/src/main/java/org/jboss/as/domain/controller/operations/deployment/ServerGroupDeploymentAddHandler.java +++ b/host-controller/src/main/java/org/jboss/as/domain/controller/operations/deployment/ServerGroupDeploymentAddHandler.java @@ -27,6 +27,7 @@ import org.jboss.as.repository.HostFileRepository; import org.jboss.as.server.deployment.ModelContentReference; import org.jboss.dmr.ModelNode; +import org.jboss.logging.Logger; /** * Handles addition of a deployment to a server group. @@ -39,6 +40,7 @@ public class ServerGroupDeploymentAddHandler implements OperationStepHandler { private final HostFileRepository fileRepository; private final ContentRepository contentRepository; + private static final Logger logger = Logger.getLogger("org.jboss.as.domain.controller.operations.deployment"); public ServerGroupDeploymentAddHandler(final HostFileRepository fileRepository, ContentRepository contentRepository) { this.fileRepository = fileRepository; @@ -94,6 +96,9 @@ static void validateRuntimeNames(String deploymentName, OperationContext context Resource root = context.readResourceFromRoot(PathAddress.EMPTY_ADDRESS); ModelNode domainDeployment = root.getChild(PathElement.pathElement(DEPLOYMENT, deploymentName)).getModel(); String runtimeName = getRuntimeName(deploymentName, deployment, domainDeployment); + if (!runtimeName.contains(".")) { + logger.warnf("Deployment '%s' has a runtime name '%s' without an extension. This may cause issues in some environments.", deploymentName, runtimeName); + } PathAddress sgAddress = address.subAddress(0, address.size() - 1); Resource serverGroup = root.navigate(sgAddress); for (Resource.ResourceEntry re : serverGroup.getChildren(DEPLOYMENT)) { diff --git a/server/src/main/java/org/jboss/as/server/deployment/DeploymentHandlerUtil.java b/server/src/main/java/org/jboss/as/server/deployment/DeploymentHandlerUtil.java index 6c8af072c7f..2ce754856ec 100644 --- a/server/src/main/java/org/jboss/as/server/deployment/DeploymentHandlerUtil.java +++ b/server/src/main/java/org/jboss/as/server/deployment/DeploymentHandlerUtil.java @@ -49,6 +49,7 @@ import org.jboss.as.server.deploymentoverlay.DeploymentOverlayIndex; import org.jboss.as.server.logging.ServerLogger; import org.jboss.dmr.ModelNode; +import org.jboss.logging.Logger; import org.jboss.msc.service.LifecycleEvent; import org.jboss.msc.service.LifecycleListener; import org.jboss.msc.service.ServiceBuilder; @@ -69,6 +70,7 @@ public class DeploymentHandlerUtil { private static final OperationContext.AttachmentKey ANNOTATION_INDEX_SUPPORT = OperationContext.AttachmentKey.create(AnnotationIndexSupport.class); + private static final Logger logger = Logger.getLogger("org.jboss.as.server.deployment"); static class ContentItem { // either hash or @@ -142,6 +144,9 @@ public static void deploy(final OperationContext context, final ModelNode operat context.addStep(new OperationStepHandler() { public void execute(OperationContext context, ModelNode operation) { + if (!deploymentUnitName.contains(".")) { + logger.warnf("Deployment '%s' has a runtime name '%s' without an extension. This may cause issues in some environments.", managementName, deploymentUnitName); + } final ServiceName deploymentUnitServiceName = Services.deploymentUnitName(deploymentUnitName); final ServiceRegistry serviceRegistry = context.getServiceRegistry(true); final ServiceController deploymentController = serviceRegistry.getService(deploymentUnitServiceName);