[WFCORE-6843] Logging a WARN if a deployment's runtime name doesn't have an extension #6340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your very quick response and sorry for the late response, I overlooked that. I will look at it now. Thanks for the information. :) |
khermano
force-pushed
the
WFCORE-6843_from_main
branch
from
2f2cb16 to
ac61cc4
Compare
yersan
requested changes
Feb 17, 2025
server/src/main/java/org/jboss/as/server/logging/ServerLogger.java
Outdated
Show resolved
Hide resolved
...-controller/src/main/java/org/jboss/as/domain/controller/logging/DomainControllerLogger.java
Outdated
Show resolved
Hide resolved
...va/org/jboss/as/domain/controller/operations/deployment/ServerGroupDeploymentAddHandler.java
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
khermano
force-pushed
the
WFCORE-6843_from_main
branch
from
ac61cc4 to
dac24f1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
yersan
requested changes
Feb 24, 2025
Comment on lines
+146
to
+148
| if (!deploymentUnitName.contains(".")) { | ||
| DEPLOYMENT_NAMECHECK_LOGGER.deploymentsRuntimeNameWithoutExtension(managementName, deploymentUnitName); | ||
| } |
There was a problem hiding this comment.
One last detail, we need to do the same for the other methods as redeploy, replace
The same applies to Domain Mode handlers, we need to cover the redeploy and replace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/WFCORE-6843