Lost battery input/output energy today entities

[mickemartinsson]

Hi,
I have lost the entities for battery input and output energy - I can no longer use Energy in Lovelace (missing flows in and out of battery). Tried to reload integration but no luck. Is this an error in my system or is there something else? It has worked perfectly before.

[infradom]

Had a quick look, on first sight these parameters seem to have disappeared from the source code, except for X1 installations. I might be wrong ... Should be easy to fix, unless there is a reason for removing them I am not aware of

[wills106]

maybe we should put them all in one of the dictionaries, then do the copy() and then remove the unneeded with pop() statements

Might be worthwhile as it's all becoming a bit of a mess to be honest.

[infradom]

Yes, it is worthwile, but may take some time if we want to avoid errors
Shall I try to do this cleanup/restructuring or do you prefer to do it yourself? I may not be able to find time before wednesday

[wills106]

I don't mind. There is no rush for it though.

Probably need to make a sensor list for each Inverter. Then we can make sure we don't loose a sensor or add in wrong sensors.

[infradom]

or create list of all sensors, but extended with flags that indicate which generations (and type: X1 or X3) it applies to.
Then we can create the entities based on the inverter type and generation in a simple python loop

[wills106]

So something a bit like:

"pv_total_power"gen2,gen3,gen4
"discharger_end_time_1"gen2,gen4
"feedine_nightcharge_upper_soc"gen4

[infradom]

no, it is not the same, today gives the numbeers for the last day, these new variables give the totals since day zero, so it gives me an indication how much money my batteries have saved since day 1

[wills106]

Ahh ok

[wills106]

So it might still give battery dashboard support for the Gen2 then. Increasing total. Just need to adapt the registers for the Gen2

[infradom]

As an example: In my system, the 'today' value returns around 7kWh, the total value returns around 800 kWh

…

On Sat, Apr 2, 2022 at 1:08 PM wills106 ***@***.***> wrote: So it might still give battery dashboard support for the Gen2 then. Increasing total. Just need to adapt the registers for the Gen2 — Reply to this email directly, view it on GitHub <#45 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2B23WHZRJP5TW7345AO43VDATDRANCNFSM5SKTXZFA> . You are receiving this because you commented.Message ID: <wills106/homsassistant-solax-modbus/repo-discussions/45/comments/2490816@ github.com>

-- Jan Colpaert +32 478 882435

[wills106]

Hopefully we can add battery for the Gen2 into the Energy dashboard.
OutputEnergy_Charge1.LSB & OutputEnergy_Charge1.MSB are the same registers between the Gen2 and Later Models.
But the InputEnergy_Charge1.LSB & InputEnergy_Charge1.MSB equivalents have moved by 1 register.

It will mess the Energy dashboard up on the first day for a Gen2 user as all of a sudden they will have a massive value in the hundreds of kWh. But going forward they should get a similar result to our input_energy_charge_today & output_energy_charge_today

Might also be handy to expose BatterySOH for the Gen2 as I am assuming that's Battery State of Health. Although I am not sure how it calculates that %

Gen2
0x001D OutputEnergy_Charge1.LSB 
0x001E OutputEnergy_Charge1.MSB 
0x001F BMS warnings
0x0020 InputEnergy_Charge1.LSB
0x0021 InputEnergy_Charge1.MSB
0x0022 BatteryPackageNum
0x0023 BatterySOH

Gen3 & Gen4
0x001D OutputEnergy_Charge.LSB
0x001E OutputEnergy_Charge.MSB
0x001F BMS Warning LSB
0x0020 OutputEnergy_Charge_today
0x0021 InputEnergy_Charge.LSB
0x0022 InputEnergy_Charge.MSB
0x0023 InputEnergy_Charge_today

[wills106]

All being well 0.4.12b should add battery input / output to the energy dashboard for Gen2

[infradom]

I would do something like: imaginary examlple (still some tuning needed) GEN2 = 0x0001 GEN3 = 0x0002 GEN4 = 0x0004 X1 = 0x0100 X3 = 0x0200 EPS = 0x1000 ALL = 0xFFFF ALL_ENTITIES = { "grid_export_total": MyEntityDescription( name="Grid Export Total", key="grid_export_total", native_unit_of_measurement=ENERGY_KILO_WATT_HOUR, icon="mdi:solar-power", device_class=DEVICE_CLASS_ENERGY, state_class=STATE_CLASS_TOTAL_INCREASING, entity_registry_enabled_default=False, ormask = GEN2 | GEN3 | GEN4 andmask = X1 | X3 ), "backup_nightcharge_upper_soc"] = MyEntityDescription( name="Backup Night Charge Upper SOC", key="backup_nightcharge_upper_soc", native_unit_of_measurement=PERCENTAGE, device_class=DEVICE_CLASS_BATTERY, ormask = GEN4 andmask = X1 ), "eps_min_esc_soc": MyEntityDescription( name="EPS Min Esc SOC", key="eps_min_esc_soc", native_unit_of_measurement=PERCENTAGE, ormask = GEN2 | GEN3 | GEN4 andmask = EPS ),

…

On Sat, Apr 2, 2022 at 1:48 PM wills106 ***@***.***> wrote: So something a bit like: "pv_total_power"gen2,gen3,gen4 "discharger_end_time_1"gen2,gen4 "feedine_nightcharge_upper_soc"gen4 — Reply to this email directly, view it on GitHub <#45 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2B23UHQP7QQZYVNNI4FXLVDAXYTANCNFSM5SKTXZFA> . You are receiving this because you commented.Message ID: <wills106/homsassistant-solax-modbus/repo-discussions/45/comments/2490903@ github.com>

-- Jan Colpaert +32 478 882435

[mickemartinsson]

Thanks!! After the update, it works again!