Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Concatenated Op axis aren't correct #82

Open
adam-hartshorne opened this issue Jan 6, 2024 · 1 comment
Open

[Bug] Concatenated Op axis aren't correct #82

adam-hartshorne opened this issue Jan 6, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@adam-hartshorne
Copy link

adam-hartshorne commented Jan 6, 2024

I think there is a bug in the Concatenated Op, where the wrong axes are being processed.

e.g. A of size (100,2), B of size (100,1)

in Cola, if you use the Concatenated op via

C = cola.ops.Concatenated(A, B, axis=0)

C will be of size (200,2)...which isn't correct.

and

C = cola.ops.Concatenated(A, B, axis=1)

will give an Assertion Error: Trying to concatenate matrices of different sizes [(100, 2), (100, 1)]

@adam-hartshorne adam-hartshorne added the bug Something isn't working label Jan 6, 2024
@mfinzi
Copy link
Collaborator

mfinzi commented Jan 28, 2024

Sorry about the late response! Good catch, I think the Concatenated op may not be as well tested as the other matrices. After the ICML deadline I will have a look into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants