Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override non existing dependancies #680

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Override non existing dependancies #680

merged 2 commits into from
Jan 4, 2024

Conversation

rdsoze
Copy link

@rdsoze rdsoze commented Jan 4, 2024

Override non existing dependancies; build was failing because sourcegraph doesn't have this repos anymore.

shalinlk
shalinlk approved these changes Jan 4, 2024
View reviewed changes
Copy link

@shalinlk shalinlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming that an implicit dependency needs to be replaced

@shalinlk
Copy link

shalinlk commented Jan 4, 2024

Please verify the original depender of replaced packages is working as expected

@rdsoze rdsoze merged commit 67ab9e9 into release/cloud-info_1.1.0 Jan 4, 2024
2 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shalinlk shalinlk shalinlk approved these changes

@abhinavsingh-ccm abhinavsingh-ccm Awaiting requested review from abhinavsingh-ccm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdsoze @shalinlk