feat: [PL-56709]: Updating PDB in services chart #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharatgoelharness
approved these changes
Sep 19, 2024
bharatgoelharness
merged commit 37fcb92
into
release/cloud-info_1.3.0
2 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pod Disruption Budgets are not configurable and for most of the services are set at minAvailable: 50%, customers require an option to configure PDBs for all services and the ability to turn them off or on.
This PR updates the PDB manifest to use the helm-common function for rendering the PDB manifest and is configurable through the override file.
The configuration is divided into two parts Global:
Global configurations will be applied to all services
Local: These have precedence over global config and can be used to specifically set values for the PDB of a service.