-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(monkeys): adding more metrics to monitor the test #2665
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would need to be ported to helm/infinitemonkeys/dashboards/monkeys.json as well, @mastaab already did some changes there. Perhaps the two files could be symlinked or reference each other.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah... we should do something like that.
my changes were more of a cosmetic thing, so no need to merge them.
fd1a638
to
61121aa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2665 +/- ##
=============================================
- Coverage 58.79% 58.71% -0.08%
Complexity 7 7
=============================================
Files 1188 1188
Lines 46311 46512 +201
Branches 4376 4386 +10
=============================================
+ Hits 27227 27311 +84
- Misses 17133 17240 +107
- Partials 1951 1961 +10 see 42 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 2875 Passed, 121 Skipped, 9m 14.04s Wall Time |
This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore. |
Datadog ReportBranch report: ✅ 0 Failed, 2928 Passed, 104 Skipped, 13m 54.01s Wall Time |
Datadog ReportBranch report: ✅ 0 Failed, 2936 Passed, 104 Skipped, 14.47s Total Time |
|
This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore. |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Fixes issue to accept null env variables and add metrics about kalium performance to grafana
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.