Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(monkeys): adding more metrics to monitor the test #2665

Closed
wants to merge 10 commits into from

Conversation

augustocdias
Copy link


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Fixes issue to accept null env variables and add metrics about kalium performance to grafana


References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would need to be ported to helm/infinitemonkeys/dashboards/monkeys.json as well, @mastaab already did some changes there. Perhaps the two files could be symlinked or reference each other.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah... we should do something like that.
my changes were more of a cosmetic thing, so no need to merge them.

@augustocdias augustocdias force-pushed the fix/monkeys/not-null branch from fd1a638 to 61121aa Compare March 19, 2024 09:25
Copy link
Contributor

github-actions bot commented Mar 19, 2024

Test Results

3 040 tests  ±0   2 936 ✔️ ±0   3m 30s ⏱️ +8s
   528 suites ±0      104 💤 ±0 
   528 files   ±0          0 ±0 

Results for commit 6251381. ± Comparison against base commit 323fad3.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.71%. Comparing base (06a032e) to head (477ae1c).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2665      +/-   ##
=============================================
- Coverage      58.79%   58.71%   -0.08%     
  Complexity         7        7              
=============================================
  Files           1188     1188              
  Lines          46311    46512     +201     
  Branches        4376     4386      +10     
=============================================
+ Hits           27227    27311      +84     
- Misses         17133    17240     +107     
- Partials        1951     1961      +10     

see 42 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06a032e...477ae1c. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Mar 19, 2024

Datadog Report

Branch report: fix/monkeys/not-null
Commit report: aab68c3
Test service: kalium-jvm

✅ 0 Failed, 2875 Passed, 121 Skipped, 9m 14.04s Wall Time

@augustocdias augustocdias marked this pull request as ready for review March 19, 2024 10:08
@augustocdias augustocdias enabled auto-merge March 19, 2024 10:08
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore.

@github-actions github-actions bot added the stale label Apr 20, 2024
@stale stale bot removed the stale label Apr 26, 2024
@mchenani mchenani self-assigned this Apr 26, 2024
@datadog-wireapp
Copy link

datadog-wireapp bot commented Apr 26, 2024

Datadog Report

Branch report: fix/monkeys/not-null
Commit report: cdc9159
Test service: kalium-jvm

✅ 0 Failed, 2928 Passed, 104 Skipped, 13m 54.01s Wall Time

@datadog-wireapp
Copy link

datadog-wireapp bot commented May 13, 2024

Datadog Report

Branch report: fix/monkeys/not-null
Commit report: 03a627b
Test service: kalium-jvm

✅ 0 Failed, 2936 Passed, 104 Skipped, 14.47s Total Time

Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore.

@github-actions github-actions bot added the stale label Jun 24, 2024
auto-merge was automatically disabled June 24, 2024 07:38

Pull request was closed

@vitorhugods vitorhugods deleted the fix/monkeys/not-null branch January 29, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants