-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pass the MLS public key signature algorithm when updating MLS public keys [WPB-8592] 🍒 #2734
feat: pass the MLS public key signature algorithm when updating MLS public keys [WPB-8592] 🍒 #2734
Conversation
Can we add the JIRA ticket here please :D |
…into feat/pass-signature-algorithm-when-registring-mls-client-cherry-pick # Conflicts: # cryptography/src/commonJvmAndroid/kotlin/com.wire.kalium.cryptography/MLSClientImpl.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/mls/CipherSuite.kt
Datadog ReportBranch report: ❌ 1 Failed (0 Known Flaky), 2902 Passed, 52 Skipped, 12.39s Total Time ❌ Failed Tests (1)
|
Signed-off-by: MohamadJaara <[email protected]>
…hen-registring-mls-client-cherry-pick
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #2734 +/- ##
====================================================
Coverage ? 58.83%
====================================================
Files ? 1213
Lines ? 47158
Branches ? 4428
====================================================
Hits ? 27745
Misses ? 17406
Partials ? 2007
Continue to review full report in Codecov by Sentry.
|
…hen-registring-mls-client-cherry-pick
|
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
pass the MLS public key signature algorithm when updating MLS public keys
Solutions
whe getting the public key form MLS client also append the cipher suite used for that key and then mapped it to a signature algorithm that is used when uploading the key to the backend
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.