Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update AVS lib to 9.7.15 (WPB-9095) 🍒 #2763

Merged
merged 2 commits into from
May 14, 2024
Merged

chore: update AVS lib to 9.7.15 (WPB-9095) 🍒 #2763

merged 2 commits into from
May 14, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 14, 2024 •
edited
Loading

BugWPB-9095 [Android] Playstore crash - Audio sensor crash

This PR was automatically cherry-picked based on the following PR:

Original PR description:

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

AVS lib crashing when a Bluetooth device was disconnected but there was still a reference to it on audioManager getAvailableCommunicationDevices()

Solutions

Update AVS lib to 9.7.15 that is now handling nullable devices from getAvailableCommunicationDevices()

@alexandreferris alexandreferris requested review from a team, typfel, mchenani, Garzas, ohassine and saleniuk and removed request for a team May 14, 2024 12:24
@alexandreferris alexandreferris enabled auto-merge May 14, 2024 12:24
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented May 14, 2024 •
edited
Loading

Test Results

3 038 tests  ±0   2 934 ✔️ ±0   3m 19s ⏱️ -4s
   528 suites ±0      104 💤 ±0 
   528 files   ±0          0 ❌ ±0 

Results for commit aea8ddf. ± Comparison against base commit 69bf489.

♻️ This comment has been updated with latest results.

@alexandreferris alexandreferris added this pull request to the merge queue May 14, 2024
@datadog-wireapp
Copy link

Datadog Report

Branch report: chore/update_avs_9_7_15-cherry-pick
Commit report: 18c279d
Test service: kalium-jvm

✅ 0 Failed, 2934 Passed, 104 Skipped, 13.05s Total Time

Merged via the queue into develop with commit f8c7a9f May 14, 2024
20 checks passed
@alexandreferris alexandreferris deleted the chore/update_avs_9_7_15-cherry-pick branch May 14, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandreferris alexandreferris alexandreferris approved these changes

@vitorhugods vitorhugods vitorhugods approved these changes

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@mchenani mchenani Awaiting requested review from mchenani mchenani was automatically assigned from wireapp/android

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

@saleniuk saleniuk Awaiting requested review from saleniuk saleniuk was automatically assigned from wireapp/android

Assignees

@alexandreferris alexandreferris

Labels
👕 size: XS type: chore 🧹
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandreferris @vitorhugods