fix: wrong failType for MLS federation errors [WPB-9087] 🍒 #2767
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
"Learn more" links in conversation error message are not displayed anymore for MLS errors when creating a conversation and adding members.
Causes (Optional)
Wrong
failType
for MLS federation errors.Solutions
Set the right
failType
, also use correctfailType
for non-retryable errors.Testing
Test Coverage (Optional)
How to Test
STR:
Expected:
The error message should have a link “Learn more” which forwards the user to an FAQ page
Actual:
The “Learn more” link is missing.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.