fix: recreate cache directories in case cache is cleared [WPB-7368] #2773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandreferris
approved these changes
May 17, 2024
|
Datadog ReportBranch report: ✅ 0 Failed, 2937 Passed, 104 Skipped, 14.43s Total Time |
yamilmedina
approved these changes
May 17, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 17, 2024
…2773) * fix: recreate cache directories in case cache is cleared [WPB-7368] * fix detekt
6 tasks
Merged
6 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 20, 2024
…2773) (#2774) * fix: recreate cache directories in case cache is cleared [WPB-7368] * fix detekt Co-authored-by: Michał Saleniuk <[email protected]>
Merged
6 tasks
echoes-hq
bot
added
the
echoes: unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
We get multiple crashes when accessing cache files (ENOENT errors) which potentially suggest that the cache is fully cleared and the app cannot find needed directories for the given user in cache to create a temporary file for that user.
Solutions
Recreate directories when getting a temporary cache file path.
Testing
How to Test
Open the app, clear app cache and try to send or download asset.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.