Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recreate cache directories in case cache is cleared [WPB-7368] 🍒 #2774

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 17, 2024

BugWPB-7368 [Android] Playstore crash - Resample Image and File handling

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We get multiple crashes when accessing cache files (ENOENT errors) which potentially suggest that the cache is fully cleared and the app cannot find needed directories for the given user in cache to create a temporary file for that user.

Solutions

Recreate directories when getting a temporary cache file path.

Testing

How to Test

Open the app, clear app cache and try to send or download asset.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…2773)

* fix: recreate cache directories in case cache is cleared [WPB-7368]

* fix detekt
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor Author

github-actions bot commented May 20, 2024

Test Results

3 039 tests  ±0   2 935 ✔️ ±0   3m 28s ⏱️ +6s
   528 suites ±0      104 💤 ±0 
   528 files   ±0          0 ±0 

Results for commit d29d901. ± Comparison against base commit e1e58c3.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/recreate-cache-directories-when-cleared-cherry-pick
Commit report: 60e8f8b
Test service: kalium-jvm

✅ 0 Failed, 2935 Passed, 104 Skipped, 13.4s Total Time

@saleniuk saleniuk added this pull request to the merge queue May 20, 2024
Merged via the queue into develop with commit 323fad3 May 20, 2024
21 checks passed
@saleniuk saleniuk deleted the fix/recreate-cache-directories-when-cleared-cherry-pick branch May 20, 2024 13:56
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. 👕 size: XS type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants