feat(new-login): epic enabling new flows for simplified enterprise login (WPB-14364) #3309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: base for get domain registration * feat: add tests and skeleton for the new endpoint * feat: test coverage for endpoint errors
* feat: add use case to observe valid sessions * revert name changes * fix detekt * revert name changes
…#3275) * feat: map login flow result * feat: map login flow result * fix: adjust domain modeling for login paths * feat: mappers, tests and data layer for getting domaing registration * feat: extract domain, better naming for use case, and tests * feat: datadog ready and better naming for result * chore: fix test * feat: rearrange and docs * chore: test improv/cov for field
…owForDomainUseCase (WPB-15520) (#3289) * refactor: returns specialized result and error handling * refactor: returns specialized result and error handling * refactor: adjust to specs already in use * refactor: adjust to specs already in use test * refactor: serverlinks ready for client navigation usage * refactor: serverlinks ready for client navigation usage * chore: add more tests
…WPB-15966) (#3287) * feat: create use case to observe current user server config * chore: cleanup code for not needed funtions * feat: use case to get the login context based on api version and proxy * feat: load login context based on api and proxy * feat: detekt * feat: address pr comments * chore: fix test * chore: fix test * chore: add more tests * chore: add more tests
* feat: error handling simplified, not needed case * feat: loggable friendly for metrics and troubleshooting
github-actions
bot
added
🚨 Potential breaking changes
type: feature ✨
👕 size: XXL
labels
|
|
Bencher Report| Branch | epic/new-sso-login-flow |
| Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | Latency | microseconds (µs) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 679.38 µs |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 601,105.60 µs |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,361,128.96 µs |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 27,681.78 µs |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3309 +/- ##
===========================================
+ Coverage 50.69% 50.72% +0.03%
===========================================
Files 1611 1633 +22
Lines 58162 58397 +235
Branches 5249 5261 +12
===========================================
+ Hits 29485 29623 +138
- Misses 26649 26745 +96
- Partials 2028 2029 +1 see 65 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3443 Passed, 110 Skipped, 1m 2.21s Total Time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Compiled epic PR divided in previously created.
Solutions
All can be seen retroactively on each small PR.
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.