-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not remove MLS from the set of supported protocols [WPB-16254] #3311
fix: do not remove MLS from the set of supported protocols [WPB-16254] #3311
Conversation
|
Test Results3 368 tests 3 258 ✅ 5m 32s ⏱️ Results for commit 68ac729. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3311 +/- ##
====================================================
Coverage ? 54.55%
====================================================
Files ? 1252
Lines ? 36695
Branches ? 3741
====================================================
Hits ? 20020
Misses ? 15252
Partials ? 1423
Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3258 Passed, 110 Skipped, 1m 2.8s Total Time |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
it can happen that a client remove MLS from the supported protocols after it is added
Solutions
try to prevent it by checking if it does exists and not remove it if it does
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.