Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not remove MLS from the set of supported protocols [WPB-16254] #3311

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Feb 25, 2025

TaskWPB-16254 [Android] Prevent removal of MLS from supported protocols if it was previously supported


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

it can happen that a client remove MLS from the supported protocols after it is added

Solutions

try to prevent it by checking if it does exists and not remove it if it does

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara changed the title fix: do not remove MLS from the set of supported protocols fix: do not remove MLS from the set of supported protocols [WPB-16254] Feb 25, 2025
Copy link
Contributor

github-actions bot commented Feb 25, 2025

Test Results

3 368 tests   3 258 ✅  5m 32s ⏱️
  572 suites    110 💤
  572 files        0 ❌

Results for commit 68ac729.

♻️ This comment has been updated with latest results.

@MohamadJaara MohamadJaara added this pull request to the merge queue Feb 25, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/candidate@58cc378). Learn more about missing BASE report.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/candidate    #3311   +/-   ##
====================================================
  Coverage                     ?   54.55%           
====================================================
  Files                        ?     1252           
  Lines                        ?    36695           
  Branches                     ?     3741           
====================================================
  Hits                         ?    20020           
  Misses                       ?    15252           
  Partials                     ?     1423           
Files with missing lines Coverage Δ
...re/user/UpdateSelfUserSupportedProtocolsUseCase.kt 90.90% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58cc378...68ac729. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/Prevent-removal-of-MLS-from-supported-protocols-if-it-was-previously-supported
Commit report: d932144
Test service: kalium-jvm

✅ 0 Failed, 3258 Passed, 110 Skipped, 1m 2.8s Total Time

Merged via the queue into release/candidate with commit 09bb717 Feb 25, 2025
20 checks passed
@MohamadJaara MohamadJaara deleted the fix/Prevent-removal-of-MLS-from-supported-protocols-if-it-was-previously-supported branch February 25, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants