Add notifications for error status codes #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-e91
requested review from
TheInkedEngineer,
gianfilippocisternino,
FabrizioBrancati,
davideruisi,
davix93,
gaetanomatonti and
MicheleMola
martin-e91
added
feature
…tions/mocka into feature/notification-upon-error # Conflicts: # Sources/App/Logic/Notification+Logic.swift # Sources/Server/NetworkExchangeMiddleware.swift
…tions/mocka into feature/notification-upon-error
…tions/mocka into feature/notification-upon-error # Conflicts: # Tests/AppTests/Notifications+Tests.swift
verebes1
reviewed
Nov 3, 2022
| let httpMethod = HTTPMethod(rawValue: request.method.rawValue)! | ||
| let receivedRequestTimeStamp = Date().timeIntervalSince1970 | ||
|
|
||
| .on($0.method.vaporMethod, $0.vaporParameter) { request -> EventLoopFuture<ClientResponse> in |
There was a problem hiding this comment.
Suggested change
| .on($0.method.vaporMethod, $0.vaporParameter) { request -> EventLoopFuture<ClientResponse> in | |
| .on($0.method.vaporMethod, $0.vaporParameter) { [weak self] request -> EventLoopFuture<ClientResponse> in |
Is it possible that the request has a strong reference?
gaetanomatonti
removed request for
FabrizioBrancati,
TheInkedEngineer and
davideruisi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the in-app notifications triggered when the server responds with an error status code (between
300and600).This also adds the notification settings tab in the Preferences allowing the user to enable/disable the notifications.
Type of Change
How Has This Been Tested?
Configuration:
OS and Version: macOS 11.5
App Version: 0.1.0
Checklist:
Screenshots
Registrazione.schermo.2021-07-29.alle.15.47.51.mov