Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a ruleset should be displayed differently #33

Open
noisy opened this issue Dec 10, 2018 · 1 comment
Open

Deleting a ruleset should be displayed differently #33

noisy opened this issue Dec 10, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@noisy
Copy link
Contributor

noisy commented Dec 10, 2018

The feature

If a user deletes a ruleset or rulsets for a user, it would be nice to see this in a different way in a Wise Hub.

Currently wise upload-rules which voides rules:

wise upload-rules
[syncing a rule][0%]: Planning updating rules: rules for wise-test2 will be voided.
[syncing a rule][0%]: Planning updating rules: rules for lenka will be voided.
[syncing a rule][0%]: Planning updating rules: rules for noisy will be voided.
[syncing a rule][0%]: Updating rules: 3 operations to send...
[syncing a rule][33%]: Updating rules: Sending operation 1/3...
[syncing a rule][66%]: Updating rules: Sent operation 1/3 ([b=28440752, tx=3, op=0])
[syncing a rule][66%]: Updating rules: Sending operation 2/3...
[syncing a rule][100%]: Updating rules: Sent operation 2/3 ([b=28440753, tx=11, op=0])
[syncing a rule][100%]: Updating rules: Sending operation 3/3...
[syncing a rule][133%]: Updating rules: Sent operation 3/3 ([b=28440754, tx=22, op=0])
[syncing a rule][100%]: Done updating rules.
Rules updated: [b=28440754, tx=22, op=0]

display log in Wise Hub which is exactly the same like in cases when rules are changed or added:

selection_999 653

It is important for me because:

It is very surprising after clicking "View the rulesets" to not see any rulesets. Without taking a look into a raw transaction, it is very difficult to understand why there is no rulsets anymore in the list.

@noisy noisy added the enhancement New feature or request label Dec 10, 2018
@Jblew Jblew self-assigned this Dec 11, 2018
@Jblew
Copy link
Member

Jblew commented Dec 11, 2018

This is complicated but possible. Thanks to wiseSQL, we can compare the rulesets. The question is where to do it.

This history/activity log is in fact an augmented version of the blockchain operations. I think, that probably we will be adding more and more features to it (showing deleted rulesets is just one of them).Some of the entries will require data that needs time consuming processing. The best idea would be to process it in wiseSQL (some special table in the database). Frontend would only need a single query to wiseSQL to display all the data

@noisy noisy unassigned Jblew Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants