Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inertial matrix is not symmetric #1

Open
huiwenzhang opened this issue Nov 18, 2024 · 3 comments
Open

inertial matrix is not symmetric #1

huiwenzhang opened this issue Nov 18, 2024 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@huiwenzhang
Copy link

Hi, the inertial matrix should be symmetric, but a lot of demos in this repo have non-symmetric inertial matrix update, pls check.

@wissem01chiha
Copy link
Owner

Hi @huiwenzhang , thanks very very much for your feedback, and sorry for late replay, for clarification, do you refer for the inertial matrix writing in the URDF of the robot or those computed in the .npy autogenerated files folder ? , for the urdf parameters , they are extracted the same of the official kinova URDF file , for the computed they may not be symmetric , and this is a problem with parameters physically Consistency which i hadn't the time to focus more, have you any fixing proposals ? i am welcoming modification

@wissem01chiha wissem01chiha added the good first issue Good for newcomers label Nov 19, 2024
@huiwenzhang
Copy link
Author

Hi, it is the computed inertial matrix. I am trying to run the parameters identification demo. To my understanding, the program will use the linear minimum parameter set the actuation trajectory to estimate the parameters in Y matrix. As for the inertial matrix, I think it is always should be symmetric, which implies only 6 of 9 elements in inertial matrix should be optimized. I checked the log, the matrix is always non-symmetric. I have't dive deep into the code.

@wissem01chiha
Copy link
Owner

wissem01chiha commented Nov 20, 2024

@huiwenzhang Hi, yes, I understand. Which script are you trying to run first? I will check the solver being used and the objective function it is trying to minimize.

@wissem01chiha wissem01chiha added bug Something isn't working help wanted Extra attention is needed labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants