Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - add select func #93

Open
mosheKerbel opened this issue Oct 16, 2019 · 2 comments
Open

Feature - add select func #93

mosheKerbel opened this issue Oct 16, 2019 · 2 comments

Comments

@mosheKerbel
Copy link
Contributor

Motivation: simulate native select
We would like to add it, what do you think? @GabiGrin

We currently use it here
https://github.com/wix/wix-style-react/blob/7cd8e25da032ed1103026ab26bf5d2a34feeb0b0/src/InputWithOptions/InputWithOptions.uni.driver.js#L35

And implementing it internally
https://github.com/wix/wix-style-react/blob/e4d9bed07c862bacce784af576e80688e6901e06/test/utils/unidriver/ReactBase.js#L52

@GabiGrin
Copy link
Contributor

Hey @mosheKerbel
My first hunch was thinking click / change should be enough, but I guess it's common enough to have it's own method. Also, puppeteer has it which affirms the idea.

I do prefer it being selected by value though, as you guys are adding the idx via data-hooks which isn't standard.
WDYT?

cc @borisd9

@mosheKerbel
Copy link
Contributor Author

Hey @mosheKerbel
My first hunch was thinking click / change should be enough, but I guess it's common enough to have it's own method. Also, puppeteer has it which affirms the idea.

I do prefer it being selected by value though, as you guys are adding the idx via data-hooks which isn't standard.
WDYT?

cc @borisd9

tagging @nitayneeman who implemented it internally. wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants