Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review primary buttons in the application #1388

Open
nondiremanuel opened this issue Oct 21, 2024 · 0 comments
Open

Review primary buttons in the application #1388

nondiremanuel opened this issue Oct 21, 2024 · 0 comments

Comments

@nondiremanuel
Copy link
Collaborator

After the work on #1380, we decided to review the different pages of the application to select which could be the primary buttons (shown in green), while currently we show everything as it was a secondary one. I made a tour of the application and found the following cases, excluding the installer which is already being taken care of with #1366:

  • Home screen of the wallet: If there is at least one coin which timelock is expired, the "Refresh coins" button should be a primary action.
    image

  • Sending a transaction ("Send" tab):

    • When "Next" button gets activated (after inserting all the required data), it should be a primary button

image

  • In the finalizing transaction screen:
    • Initially, "Sign" should be primary

image

  • After signing, "Broadcast" should be primary

image

  • In the popup showing up to confirm broadcasting, "Broadcast" should be primary

image

  • "Receive" screen: here it is not clear what should the primary action be. I imagine it is mainly used to copy the address, so maybe the copy button should be the primary one.

  • When opening a coin (e.g. from the "Coins" tab): if timelock expired, also here the "Refresh coin" button should be primary.
    image

  • When opening an unconfirmed tx: here I believe "Bump fee" should be the primary button, but it has to be discussed if instead we consider "Cancel transaction" at the same level of hierarchy; in that case leaving both secondary would be better.
    image

  • In the "PSBTs" tab I don't think there is a clear primary button. Maybe "New", but I don't think it is the standard flow to create a new PSBT. I would leave everything secondary at the moment.

  • In Settings>Node: when entering a rescan date, "Start Rescan" should be primary
    image

  • In Settings>Recovery: "Next" should be primary when active
    image

Am I missing anything? Feel free to add or discuss any of the above points.

@nondiremanuel nondiremanuel moved this to To be discussed / defined in Liana General Oct 21, 2024
@nondiremanuel nondiremanuel added this to the UI fixes - Liana milestone Oct 21, 2024
@nondiremanuel nondiremanuel added the Nice to have If it's not completed in time for the current version, it can be postponed label Oct 23, 2024
@nondiremanuel nondiremanuel removed the Nice to have If it's not completed in time for the current version, it can be postponed label Nov 12, 2024
@nondiremanuel nondiremanuel moved this from To be discussed / defined to Todo in Liana General Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant