Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Filename #334

Open
FloatingMind12 opened this issue Mar 10, 2024 · 4 comments
Open

Wrong Filename #334

FloatingMind12 opened this issue Mar 10, 2024 · 4 comments
Labels
bug for issue

Comments

@FloatingMind12
Copy link

Provide environment information

/home/phoe/.venv/bin/python
Python 3.11.4
gdown 5.1.0

What OS are you using?

Ubuntu 23.04

Describe the Bug

The output filename is not automatically set anymore, instead I get something like "download?...&confirm=t&...&uuid=...".
Maybe it's something related to how the download link was changed to https://drive.usercontent.google.com/download?id=...

Expected Behavior

I expect gdown to get the right filename

To Reproduce

Just download any file using the gdown command

@FloatingMind12 FloatingMind12 added the bug for issue label Mar 10, 2024
@oleksandr-poberezhnyi
Copy link

similar problem.

@Michaelfun
Copy link

same with me

@Michaelfun
Copy link

Michaelfun commented May 2, 2024

I found a way to get the right filename, in sitepackage in gdown library, then in download.py line 358 change
if tmp_file: f.close() shutil.move(tmp_file, output)
to
if tmp_file: f.close() filename_from_url = os.path.join(output,filename_from_url) shutil.move(tmp_file, filename_from_url)
that fixed everthing for me now file come with right file name

@wkentaro
Copy link
Owner

It won't reproduce for me. Can you give me an example?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug for issue
Projects
None yet
Development

No branches or pull requests

4 participants