-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stickyActionBar should add a padding to main content #317
Comments
@dario-digregorio Thanks for opening the issue. This is included in our big part of refactoring coming up soon, and almost ready. We are soon evaluating the final look with @MbIXjkee and @KristinaZoteva I would really appreciate your contribution though regarding the Instagram modal sheet style dragging capability as we discussed at Flutter&friends. |
Is there already an issue for that? |
@dario-digregorio there is not yet unfortunately, but I will work on it. |
I can create one too |
@dario-digregorio Thank you! If you can provide the design specs in your mind in the issue, I can send those for review to our designers and provide feedback to you. |
really looking forward to the upcoming rework! Just for clarification: Do you have an approx. timeline when the update will be published? Just asking so I know weather to look for a interim solution or just wait until the update is published. |
@blingkonnerth We had a meeting with @MbIXjkee and @KristinaZoteva yesterday. They have completed the technical proof of concept. The internal changes are significant. We will introduce an internal Navigator widget, each page will be a widget, and the SAB size calculation will be done during the same frame so that its spacing will be considered when laying out the main content. Mikhail and Kristina will be on vacation for the next 2 weeks, and meanwhile, I will focus on:
Our target is 6th October to have the final meeting, and during October, we can release it. Only hoping that the migration will be smooth and users will stay happy. |
sounds fantastic. Thanks for the update, can't say it enough: Awesome work! |
It would be fantastic if we could use a
|
Hi @ulusoyca , happy new year! I guess the refactor is a bit more complex than first thought? 😬 Do you have any updates on how it's going? :) |
What feature would you like to see?
When adding a
stickyActionBar
there should be a padding added to the main content otherwise the action bar overlaps the main content. I don't want to add a hardcoded padding like in the example with_bottomPaddingForButton
. The Padding should have the same size as the widget from thestickyActionBar
.I would work on a PR to fix this.
The text was updated successfully, but these errors were encountered: