Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stickyActionBar should add a padding to main content #317

Open
dario-digregorio opened this issue Aug 31, 2024 · 10 comments
Open

stickyActionBar should add a padding to main content #317

dario-digregorio opened this issue Aug 31, 2024 · 10 comments
Labels
enhancement New feature or request

Comments

@dario-digregorio
Copy link

What feature would you like to see?

When adding a stickyActionBar there should be a padding added to the main content otherwise the action bar overlaps the main content. I don't want to add a hardcoded padding like in the example with _bottomPaddingForButton. The Padding should have the same size as the widget from the stickyActionBar.

I would work on a PR to fix this.

@dario-digregorio dario-digregorio added the enhancement New feature or request label Aug 31, 2024
@ulusoyca
Copy link
Collaborator

ulusoyca commented Sep 4, 2024

@dario-digregorio Thanks for opening the issue. This is included in our big part of refactoring coming up soon, and almost ready. We are soon evaluating the final look with @MbIXjkee and @KristinaZoteva

I would really appreciate your contribution though regarding the Instagram modal sheet style dragging capability as we discussed at Flutter&friends.

@dario-digregorio
Copy link
Author

Is there already an issue for that?

@ulusoyca
Copy link
Collaborator

ulusoyca commented Sep 4, 2024

@dario-digregorio there is not yet unfortunately, but I will work on it.

@dario-digregorio
Copy link
Author

I can create one too

@ulusoyca
Copy link
Collaborator

ulusoyca commented Sep 4, 2024

@dario-digregorio Thank you! If you can provide the design specs in your mind in the issue, I can send those for review to our designers and provide feedback to you.

@blingkonnerth
Copy link

really looking forward to the upcoming rework! Just for clarification: Do you have an approx. timeline when the update will be published? Just asking so I know weather to look for a interim solution or just wait until the update is published.

@ulusoyca

@ulusoyca
Copy link
Collaborator

ulusoyca commented Sep 5, 2024

@blingkonnerth We had a meeting with @MbIXjkee and @KristinaZoteva yesterday. They have completed the technical proof of concept. The internal changes are significant. We will introduce an internal Navigator widget, each page will be a widget, and the SAB size calculation will be done during the same frame so that its spacing will be considered when laying out the main content.

Mikhail and Kristina will be on vacation for the next 2 weeks, and meanwhile, I will focus on:

  1. How we can make the migration as smooth as possible
  2. How we can keep the parity with all the features
  3. How we can integrate the default Wolt design specs (the new implementation will open the door for full customization)

Our target is 6th October to have the final meeting, and during October, we can release it. Only hoping that the migration will be smooth and users will stay happy.

@blingkonnerth
Copy link

sounds fantastic. Thanks for the update, can't say it enough: Awesome work!

@gazialankus
Copy link
Contributor

It would be fantastic if we could use a SliverOverlapAbsorber/SliverOverlapInjector for this purpose. However we're not in a NestedScrollView. Just a thought.

======== Exception caught by widgets library =======================================================
The following assertion was thrown building ValueListenableBuilder<int>(dirty, state: _ValueListenableBuilderState<int>#41ff3):
NestedScrollView.sliverOverlapAbsorberHandleFor must be called with a context that contains a NestedScrollView.
'package:flutter/src/widgets/nested_scroll_view.dart':
Failed assertion: line 334 pos 7: 'target != null'

@blingkonnerth
Copy link

Hi @ulusoyca , happy new year! I guess the refactor is a bit more complex than first thought? 😬

Do you have any updates on how it's going? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants