Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove direct use of CTL Enqueue function when BN game data support is merged #56

Closed
Meorawr opened this issue May 7, 2024 · 0 comments · Fixed by #59
Closed

Remove direct use of CTL Enqueue function when BN game data support is merged #56

Meorawr opened this issue May 7, 2024 · 0 comments · Fixed by #59
Assignees
@Meorawr
Labels
enhancement New feature or request

Comments

@Meorawr
Copy link
Member

Meorawr commented May 7, 2024

Depends upon WoWUIDev/Ace3#14 being merged in.

For now we're just going to work around that by calling the Enqueue function directly, which is still bad but certainly no where near as bad as the old "let's replace all of CTL's functions" nonsense.
@Meorawr Meorawr added the enhancement New feature or request label May 7, 2024
@Meorawr Meorawr self-assigned this May 7, 2024
Meorawr added a commit that referenced this issue May 7, 2024
@Meorawr
Use CTL's new shiny BNSendGameData API
35278be 
Fixes #56. CTL version 29 or newer now has the necessary public API
to support sending messages over Battle.net, so we no longer need to
reach in and call the Enqueue method manually.
@Meorawr Meorawr mentioned this issue May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Meorawr Meorawr

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use CTL's new shiny BNSendGameData API wow-rp-addons/Chomp
1 participant
@Meorawr