From 0149db585ae09e1867270712b0e87e883bec4081 Mon Sep 17 00:00:00 2001 From: Adrian Klingen Date: Thu, 30 Jan 2025 13:42:23 +0100 Subject: [PATCH] Add spell masks --- sim/mage/combustion.go | 6 +++--- sim/mage/talents_fire.go | 4 ++++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/sim/mage/combustion.go b/sim/mage/combustion.go index 076d4fa523..7c959b1f6d 100644 --- a/sim/mage/combustion.go +++ b/sim/mage/combustion.go @@ -152,9 +152,9 @@ func (mage *Mage) registerCombustionSpell() { }) core.MakeProcTriggerAura(&mage.Unit, core.ProcTrigger{ - Name: "Combustion Ignite listener", - ClassSpellMask: MageSpellIgnite, - Callback: core.CallbackOnPeriodicDamageDealt, + Name: "Combustion Dot Calculation Listener", + ClassSpellMask: MageSpellIgnite | MageSpellPyroblastDot | MageSpellLivingBombDot, + Callback: core.CallbackOnCastComplete | core.CallbackOnPeriodicDamageDealt, Handler: func(sim *core.Simulation, spell *core.Spell, _ *core.SpellResult) { updateCombustionTickDamageEstimate(sim) updateCombustionTotalDamageEstimate(sim) diff --git a/sim/mage/talents_fire.go b/sim/mage/talents_fire.go index 580436bf96..e9c0930a5a 100644 --- a/sim/mage/talents_fire.go +++ b/sim/mage/talents_fire.go @@ -374,6 +374,10 @@ func (mage *Mage) applyIgnite() { return result.Damage * igniteDamageMultiplier * masteryMultiplier }, }) + + // This is needed because we want to listen for the spell "cast" event that refreshes the Dot + mage.Ignite.Flags ^= core.SpellFlagNoOnCastComplete + } func (mage *Mage) applyImpact() {