Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest Reforges not working for Protection Warrior with custom EP weights #1100

Closed
decio opened this issue Oct 15, 2024 · 3 comments
Closed

Comments

@decio
Copy link

decio commented Oct 15, 2024

Steps to reproduce the behavior:

  1. Go to https://wowsims.github.io/cata/warrior/protection/
  2. Add any custom EP weight, it can be any stat and value, for example set melee hit to 2%.
  3. Click on Suggest Reforges.
  4. No reforge is suggested to achieve the 2% melee hit.

image

  • Browser Chrome, version 129.0.6668.101

I tested with a few other classes and specs and this process works, even with Arms or Fury warrior, changing any custom EP weight and clicking Suggest Reforge will give reforge results to achieve the respective custom stat, but does not seem to work with Protection warrior.

@1337LutZ
Copy link
Contributor

1337LutZ commented Oct 17, 2024

@decio works for me.
Are you sure you upped the Stat Weight for Hit to be above other stats?
Also make sure to read the description of custom EP weights
image
image

@decio
Copy link
Author

decio commented Oct 17, 2024

Well, I'm not sure what I'm doing wrong then, no matter what value of hit or the value of any other stat I set, low or high, nothing changes. Even if I increase or decrease the current weight of hit in the Stat Weights screen, I get no reforges suggestions for my custom hit weight, same with any other stat.

Maybe I'm not understanding correctly how the custom EPs are suppose to work? I thought it's weird that it works out of the bat for any other spec/class but not for prot warriors.

If it is indeed working, I guess you can go ahead and close this.

@1337LutZ
Copy link
Contributor

@decio prot warrior doesn't have Hit as a reforge stat by default and almost all other classes do.

  1. You can reset to defaults
  2. Change Hit stat weight to 8 or something (a bit above other stats)
  3. Enable custom EP in Suggest options
  4. Set hit to a %
  5. Press reforge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants