Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Suggest Reforges' sometimes removes all reforges #1208

Closed
stako opened this issue Nov 15, 2024 · 2 comments
Closed

'Suggest Reforges' sometimes removes all reforges #1208

stako opened this issue Nov 15, 2024 · 2 comments

Comments

@stako
Copy link

stako commented Nov 15, 2024

Describe the bug
Clicking the 'suggest reforges' button sometimes removes all reforges

To Reproduce
Steps to reproduce the behavior:

  1. Restore Defaults
  2. Use WowSimsExporter addon to import gear/talents/etc
  3. Click 'Suggest Reforges'
  4. After some loading time, reforges are all removed

Expected behavior
After clicking 'Suggest Reforges' expected to have gear reforged approriately.

Sim Links and Screenshots
Sim Link

Desktop (please complete the following information):

  • OS: Win 10
  • Browser: Firefox 132
  • Version: Wowsims 0.0.137 (Running locally)

Additional context

  • Only happens with some gear/spec combinations. I've noticed my combat rogue sim having slow reforges fairly regularly
  • Likely resultant from the timeout reduction to 10 seconds made in commit 4fb2e32
  • Anecdotally works fine in Chrome 130 - I guess Firefox is slower
@NerdEgghead
Copy link
Contributor

Can you try again on Firefox after a refresh and see if it works now? (It will still take a very long time compared to Chrome, Firefox performance is just intrinsically awful.)

@stako
Copy link
Author

stako commented Nov 16, 2024

Looks to be working now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants