Crash Report -2145705395

[AxPython]

Link:
https://wowsims.github.io/cata/paladin/retribution/#eJzlkj9oFEEUxvd7b3O5jELGI8V4ILcuCktA2NtrYgp3kyplytgpxGBhIXZ2l+6ioodXXHKFcISAIMFgFU78s0HQwEWPK6KIIoiaQ0UFiUaI4OxuUmh3iJUfU7z5zffNGx4jDqchEeA0zqIEzALXgfvAM6ADFAklwhJhVEgMYQwT2pgxso97apwaP3Py/KlzOm5m30BkZOMpqy+WnboxZ5Zn2alBmPJWi0W//LbN6r1l86cqO2UIIb+2WH3PRZaMvPuT1aucndKHm9U4JuXlB6x+5GxTM8O5GJF72vVBk82IVKEvXdrgOLRzab+8rftfs3aZBu0NVtu5pO00RK9cXGanArFXvqibCb4a4WKHnYWoWF2O+wu58oTV2gGnDmGIPjn/jmO3vScNV43rIZSBwUUSWzD+U2XcbhPDxqjRQCprClJo0DHPLbiu5/6mI3+CGHoF7fXyemlFoUI+v0KH0jffkny5TupKSFYpJKcSkjsT0tClkIJOm8aabXpEZot6n5PxmnTXDk1Oc/KagaC+Ux0PLrBhN6kv3hWngn27jv21uUir/tGEtPyDU7HW/ZG1ZqSPvlcha0L1DP7jn+DMBN3Yi5MPu/L/jZLh3PkcjCT7Lf8EfgHXsJjq

RNG Seed: 1504668154

simulation failed: No random suffix with id: -225
Stack Trace:
goroutine 21 [running]:
runtime/debug.Stack()
/opt/hostedtoolcache/go/1.21.11/x64/src/runtime/debug/stack.go:24 +0x6
github.com/wowsims/cata/sim/core.runSim.func1()
/home/runner/work/cata/cata/sim/core/sim.go:124 +0x10
panic({0x107ac0, 0x395aa90})
/opt/hostedtoolcache/go/1.21.11/x64/src/runtime/panic.go:914 +0x2c
github.com/wowsims/cata/sim/core.NewItem({0xff5a, 0xffffff1f, 0x0, {0x3312100, 0x2, 0x2}, 0x0})
/home/runner/work/cata/cata/sim/core/database.go:343 +0x35
github.com/wowsims/cata/sim/core.NewEquipmentSet({{0xebba, 0x0, 0x1070, {0x3312398, 0x2, 0x2}, 0x9a}, {0xf3ef, 0x0, 0x0, ...}, ...})
/home/runner/work/cata/cata/sim/core/database.go:420 +0x6
github.com/wowsims/cata/sim/core.ProtoToEquipment(0x328dd40)
/home/runner/work/cata/cata/sim/core/database.go:427 +0xd
github.com/wowsims/cata/sim/core.NewCharacter(0x321c480, 0x0, 0x3358b60)
/home/runner/work/cata/cata/sim/core/character.go:118 +0x39
github.com/wowsims/cata/sim/core.NewAgent(0x321c480, 0x0, 0x3358b60)
/home/runner/work/cata/cata/sim/core/agent.go:172 +0x1e
github.com/wowsims/cata/sim/core.NewParty(0x31cedc0, 0x0, 0x33ff450)
/home/runner/work/cata/cata/sim/core/raid.go:34 +0x1d
github...

[1337LutZ]

@AxPython When importing your link it seems to not throw an error. Could you provide a step-by-step to reproduce this?

[AxPython]

I cant reproduce it exactly right now because I'm having issues exporting items from my bag, but I was trying to use the batch sim feature.

I was using my gear preset I made, I imported gear from bags then deselected all except the belts and when I tried to run the sim it would hit me with an error and refuse to run. Then it gave me the option to auto post this to github so I thought I would if it would help.

I can try again tomorrow or when I can get bag export working properly to see if I can reproduce

[1337LutZ]

@AxPython Good to know!
Would be great if you can then also post the import string you've used for your bag items :)

[AxPython]

Managed to reproduce this with the steps I had before however bag items are slightly different, equipped are slightly different and RNG seed is different, however it's the same crash. Attempted to do batch sim with only the belts selected. Here is the bag items string from WSE that I used:

{"items":[{"enchant":4270,"gems":[52219,52237],"id":58102},{"id":59233,"gems":[]},{"id":52353,"gems":[]},{"enchant":4061,"gems":[52089],"id":56428},{"enchant":4085,"gems":[],"id":69764},{"enchant":4217,"gems":[],"id":65036},{"enchant":4206,"gems":[52293,59480,59493],"id":59359},{"id":52352,"gems":[]},{"enchant":4090,"gems":[],"id":62383},{"enchant":4217,"gems":[],"id":56459},{"id":62447,"gems":[]},{"enchant":4086,"gems":[],"id":62449},{"id":69833,"gems":[],"random_suffix":-127},{"enchant":4208,"gems":[68779,52206],"id":65130},{"id":65370,"gems":[],"random_suffix":-225},{"enchant":3789,"gems":[],"id":65165},{"id":52351,"gems":[]},{"id":62384,"gems":[52237,52219]},{"id":65059,"gems":[]},{"id":63490,"gems":[],"random_suffix":-204},{"enchant":4063,"gems":[52206],"id":55060},{"id":56337,"gems":[52219]},{"id":62351,"gems":[]},{"enchant":4094,"gems":[52219],"id":62418}]}

[AxPython]

Also attaching this crash report string from the crash just now:

Simulation Failure:
simulation failed: No random suffix with id: -225
Stack Trace:
goroutine 1271 [running]:
runtime/debug.Stack()
/opt/hostedtoolcache/go/1.21.11/x64/src/runtime/debug/stack.go:24 +0x5e
github.com/wowsims/cata/sim/core.runSim.func1()
/home/runner/work/cata/cata/sim/core/sim.go:124 +0x98
panic({0x13a87c0?, 0xc001fd4010?})
/opt/hostedtoolcache/go/1.21.11/x64/src/runtime/panic.go:914 +0x21f
github.com/wowsims/cata/sim/core.NewItem({_, _, , {, _, }, })
/home/runner/work/cata/cata/sim/core/database.go:343 +0x69a
github.com/wowsims/cata/sim/core.NewEquipmentSet({{0xebba, 0x0, 0x1070, {0xc000cb6108, 0x2, 0x2}, 0x9a}, {0xe832, 0x0, 0x0, ...}, ...})
/home/runner/work/cata/cata/sim/core/database.go:420 +0x107
github.com/wowsims/cata/sim/core.ProtoToEquipment()
/home/runner/work/cata/cata/sim/core/database.go:427 +0x158
github.com/wowsims/cata/sim/core.NewCharacter(, _, _)
/home/runner/work/cata/cata/sim/core/character.go:118 +0x56f
github.com/wowsims/cata/sim/core.NewAgent(0xc0000a4ea0?, 0x0?, 0xc000c12700)
/home/runner/work/cata/cata/sim/core/agent.go:172 +0x10a
github.com/wowsims/cata/sim/core.NewParty(0xc00068e000, 0x0, 0xc000cb0780)
/home/runner/work/cata/cata/sim/core/raid.go:34 +0x1dc
github.com/wowsims/cata/sim/core.NewRaid(0xc001d2dd00)
/home/runner/work/cata/cata/sim/core/raid.go:167 +0x1e5
github.com/wowsims/cata/sim/core.(*Environment).construct(0xc0000a4d80, 0xc001d2dd00, 0xc001d2de80)
/home/runner/work/cata/cata/sim/core/environment.go:73 +0xfa
github.com/wowsims/cata/sim/core.NewEnvironment(0xc00007e800?, 0xc0015431d0?, 0xba?)
/home/runner/work/cata/cata/sim/core/environment.go:54 +0x54
github.com/wowsims/cata/sim/core.NewSim(0xc000cb0730)
/home/runner/work/cata/cata/sim/core/sim.go:189 +0x25
github.com/wowsims/cata/sim/core.runSim(0xc000cb0730, 0xc000709c80, 0x0, 0x0)
/home/runner/work/cata/cata/sim/core/sim.go:140 +0x8b
github.com/wowsims/cata/sim/core.(*bulkSimRunner).getRankedResults.func2.2({0xc000cb0730?, 0xc000b98160?, 0xc0005f36c8?})
/home/runner/work/cata/cata/sim/core/bulksim.go:383 +0x74
created by github.com/wowsims/cata/sim/core.(*bulkSimRunner).getRankedResults.func2 in goroutine 1267
/home/runner/work/cata/cata/sim/core/bulksim.go:377 +0x79

[1337LutZ]

@rosenrusinov Assigning this to you. I see -225 exists in the Database, however when importing this into the bulk sim bag import:

{
  "items": [{ "id": 65370, "gems": [], "random_suffix": -225 }]
}

Makes it fail when trying to sim. Frontend resolves the suffix properly

[rosenrusinov]

@ToxicKevinFerm can you think of why this reforge is not found during bulk sim? I'm not that familiar with the reforge db building so maybe we are building only a list of reforges for currently equipped gear? this is random suffix not reforge, I need to read better xD

[rosenrusinov]

I have found the issue and it is exactly what I'm describing above but for random suffix instead of reforges (they work the same). It looks like the bulk sim request item db is not building the randomSuffix/reforges data from the bulk items.