-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DK Ghoul Crit Rate Too High #729
Comments
You sample size is very small to make an assumption that melee and claw are using different crit tables. To me they look like they use the same and its just RNG. I dont think LotP affects pets in-game and it does not in the sim atm. If you're seeing it affect them in-game we have to enable it for the sim for pets then. |
I mean that the crit from LotP on the player transfers to the pet. It currently works that way on the sim. The only thing I think the ghoul shouldn't gain crit from is the player's agility. I will do more testing. |
Ahh i understand what you mean. Yes right now the crit that the owner gets from lotp is transfered maybe that shouldnt happen. I dont have tests for that. |
I checked simulationcraft and it is just showing ghoul crit=player melee crit with no base crit. Which is definitely wrong. |
Your ingame tests show that we have it wrong somewhere and I think you're probably right with the guess it is to do with base agi or the crit per agi formula. If we cant figure out exactly which part of the base is wrong I can just remove the agi to crit scaling from the ghoul and give it a flat 5% base. Considering there are no buffs that affect the agility of the ghoul that should work. |
I did another 3500 and my total is now 8469 hits, 461 crits. 5.44% crit rate minus my .48% base crit is 4.96%. I think a base 5% would be close enough. I can't find any other info. |
That data set is good enough for me to just go with 5% base. |
The sim is showing my ghoul as having 10% crit vs lvl 88 mobs while in game I'm seeing it as almost half that amount with a 600 hit test:
The sim is showing my ghoul inheriting 827 crit rating which is the rating after converting all my agi into crit rating. I believe the ghoul should only be inheriting the crit rating I have on gear which is 337:
I believe there might be something else wrong with ghoul crit chance because removing the 490 rating doesn't fully explain the ~4.5% gap between the sim and game. I don't if it is crit rating conversion being wrong for ghoul, attack tables being incorrect, or crit suppression. Or maybe something else.
The text was updated successfully, but these errors were encountered: