Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DK Ghoul Crit Rate Too High #729

Closed
Cazera90 opened this issue Jun 17, 2024 · 9 comments · Fixed by #758
Closed

DK Ghoul Crit Rate Too High #729

Cazera90 opened this issue Jun 17, 2024 · 9 comments · Fixed by #758

Comments

@Cazera90
Copy link

The sim is showing my ghoul as having 10% crit vs lvl 88 mobs while in game I'm seeing it as almost half that amount with a 600 hit test:
ghoulsim
ghoulcrit

The sim is showing my ghoul inheriting 827 crit rating which is the rating after converting all my agi into crit rating. I believe the ghoul should only be inheriting the crit rating I have on gear which is 337:
ghoul inher
crit

I believe there might be something else wrong with ghoul crit chance because removing the 490 rating doesn't fully explain the ~4.5% gap between the sim and game. I don't if it is crit rating conversion being wrong for ghoul, attack tables being incorrect, or crit suppression. Or maybe something else.

@Cazera90
Copy link
Author

Looked through my logs and it looks like Leader of the Pack 5% applies to ghouls and also the crit rate difference between melee and claw leads me to think the attack tables are wrong since in the sim both have the same crit rate. (100-24)x.121=9.2% crit which is what the logs show for melees.
ghoulcrit

@Cazera90 Cazera90 reopened this Jun 17, 2024
@rosenrusinov
Copy link
Contributor

You sample size is very small to make an assumption that melee and claw are using different crit tables. To me they look like they use the same and its just RNG. I dont think LotP affects pets in-game and it does not in the sim atm. If you're seeing it affect them in-game we have to enable it for the sim for pets then.

@Cazera90
Copy link
Author

I mean that the crit from LotP on the player transfers to the pet. It currently works that way on the sim. The only thing I think the ghoul shouldn't gain crit from is the player's agility. I will do more testing.

@rosenrusinov
Copy link
Contributor

Ahh i understand what you mean. Yes right now the crit that the owner gets from lotp is transfered maybe that shouldnt happen. I dont have tests for that.

@Cazera90
Copy link
Author

I removed all crit from the sim except the base 118 agi my draenei has and simmed vs a lvl 85 enemy to try and find the ghoul's base crit chance. The sim shows 10.7% crit:
basesim
inheritedcrit

Then in game I tested vs the lvl 85 dummy with only my base crit for 2000 attacks:
critnohorn

Then again while keeping Horn of Winter up:
crithorn

I think I was wrong and the ghoul does inherit crit from the player's agi.

I decided to do another 3k without horn:
crit2

Is there a chance the ghoul has the wrong base agility? It seems to gain ~2.3% crit from my horn of winter which is how it is on the sim. I think it just gains whatever crit% you have on your sheet. It could also be that the ghoul has the incorrect agi to crit ratio for its own agility. Currently it has 3333 agi and gains 1% crit per 324.75 agi.

@Cazera90
Copy link
Author

I checked simulationcraft and it is just showing ghoul crit=player melee crit with no base crit. Which is definitely wrong.

@rosenrusinov
Copy link
Contributor

Your ingame tests show that we have it wrong somewhere and I think you're probably right with the guess it is to do with base agi or the crit per agi formula. If we cant figure out exactly which part of the base is wrong I can just remove the agi to crit scaling from the ghoul and give it a flat 5% base. Considering there are no buffs that affect the agility of the ghoul that should work.

@Cazera90
Copy link
Author

I did another 3500 and my total is now 8469 hits, 461 crits. 5.44% crit rate minus my .48% base crit is 4.96%. I think a base 5% would be close enough. I can't find any other info.

@rosenrusinov
Copy link
Contributor

That data set is good enough for me to just go with 5% base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants